Skip to content

chore(release): add liuhao1024 email mappings to AUTHOR_MAP - #18779

Closed
liuhao1024 wants to merge 1 commit into
NousResearch:mainfrom
liuhao1024:chore/add-liuhao1024-author-map
Closed

chore(release): add liuhao1024 email mappings to AUTHOR_MAP#18779
liuhao1024 wants to merge 1 commit into
NousResearch:mainfrom
liuhao1024:chore/add-liuhao1024-author-map

Conversation

@liuhao1024

@liuhao1024 liuhao1024 commented May 2, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Add the two commit emails used by liuhao1024 to the Contributor Attribution Map:

Related Issue

N/A

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)

Changes Made

  • See commit messages for detailed changes

How to Test

  1. Run pytest tests/ -q — all tests should pass
  2. Verify the specific scenario described above is resolved

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: macOS 26.4.1

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture and workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A

@alt-glitch alt-glitch added type/docs Documentation improvements P3 Low — cosmetic, nice to have labels May 2, 2026
Add the two commit emails used by liuhao1024:
- liuhao1024@users.noreply.github.com (GitHub noreply)
- sunsky.lau@gmail.com (personal)

These were flagged by the Contributor Attribution Check CI on PRs NousResearch#18734,
NousResearch#18491, NousResearch#18009, and NousResearch#17761.
@liuhao1024
liuhao1024 force-pushed the chore/add-liuhao1024-author-map branch 2 times, most recently from b3613ab to 1f87be8 Compare May 2, 2026 16:36
@liuhao1024

Copy link
Copy Markdown
Contributor Author

Status Update

This PR adds sunsky.lau@gmail.com to AUTHOR_MAP. Note that PR #18895 includes this same mapping change AND fixes 8+ upstream test failures. If #18895 is merged first, this PR becomes redundant.

Current CI:

  • check-attribution: ✅ PASS
  • test: ❌ FAIL (pre-existing upstream failures — same tests that fail on upstream main)

The test failures are NOT caused by this PR's 1-line change to scripts/release.py.

@teknium1

Copy link
Copy Markdown
Contributor

This appears to be implemented on current main, so this PR is now redundant.

Automated hermes-sweeper review evidence:

  • scripts/release.py:200 maps liuhao1024@users.noreply.github.com to liuhao1024.
  • scripts/release.py:1101 maps sunsky.lau@gmail.com to liuhao1024.
  • scripts/release.py:506 still contains the existing liuhao03@bilibili.com mapping mentioned in the PR body.
  • The last missing requested mapping was added on main by 4c646388972ba1805c07a6e6a0d69be14dd260d8 (chore(release): map liuhao1024 for PR #20778 salvage), which is contained in v2026.5.28 and later release tags.

Thanks for flagging the attribution issue and for noting in the discussion that this would become redundant if the mapping landed elsewhere.

@teknium1 teknium1 closed this Jun 10, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have sweeper:implemented-on-main Sweeper: behavior already present on current main type/docs Documentation improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants