fix(discord): register goal slash command (#21589) - #22105
Closed
Tranquil-Flow wants to merge 2 commits into
Closed
Conversation
Tranquil-Flow
force-pushed
the
fix/21589-discord-goal-slash-command
branch
from
May 25, 2026 09:11
1ecd93a to
a109d1a
Compare
CI Attribution Check Fix (auto-heal)The A fix has been opened as PR #31982: Once merged, this email will be mapped to your GitHub username ( Ref: CI run https://github.com/NousResearch/hermes-agent/actions/runs/26392838715 |
Tranquil-Flow
force-pushed
the
fix/21589-discord-goal-slash-command
branch
from
May 25, 2026 11:03
a109d1a to
9ae4b08
Compare
Contributor
|
This looks implemented on current Evidence from an automated hermes-sweeper review:
Thanks for filing the targeted fix and test; the broader registry-based fix on main now covers the same bug class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Registers Discord's native
/goalslash command so Discord interactions route to the existing gateway/goalcommand instead of timing out with "Application did not respond". The fix reuses the existing simple slash-command dispatch path and does not change goal command semantics.Related Issue
Fixes #21589
Type of Change
Changes Made
gateway/platforms/discord.py: add the missingslash_goalregistration.tests/gateway/test_discord_slash_commands.py: verify/goalis registered and invokes_run_simple_slash(interaction, "/goal").How to Test
python3 -m pytest tests/gateway/test_discord_slash_commands.py -k 'goal_slash_command' -o 'addopts=' --tb=short -qpython3 -m pytest tests/gateway/test_discord_slash_commands.py -o 'addopts=' --tb=short -qdiscord.pyhandler reverted, the new goal slash command test fails.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs