chore: add briandevans noreply email to AUTHOR_MAP - #11682
Closed
briandevans wants to merge 1 commit into
Closed
Conversation
The briandevans GitHub noreply form (``252620095+briandevans@users.noreply.github.com``) is not in ``AUTHOR_MAP``, so when a salvage commit of my work is authored against that address (the form my local ``git config user.email`` produces on GitHub-default setups), ``scripts/release.py``'s strict mode fails to resolve it to the ``briandevans`` GitHub handle. Only ``brian@bde.io`` is currently mapped; add the noreply form next to it so both local and GitHub-UI-attributed commits are covered. Mirrors the pattern used for kshitijk4poor in NousResearch#11120 and the batch in NousResearch#11076. Verified via: python -c "import ast, pathlib, sys; tree = ast.parse(pathlib.Path('scripts/release.py').read_text()); d = next(ast.literal_eval(n.value) for n in ast.walk(tree) if isinstance(n, ast.Assign) and any(getattr(t, 'id', None) == 'AUTHOR_MAP' for t in n.targets)); assert d['252620095+briandevans@users.noreply.github.com'] == 'briandevans'; print(len(d))" # -> 211 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an additional GitHub noreply email variant for briandevans to the release attribution author mapping, preventing contributor_audit strict-mode failures when commits are authored with GitHub’s default noreply email format.
Changes:
- Add
252620095+briandevans@users.noreply.github.com→briandevanstoAUTHOR_MAPinscripts/release.py.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alt-glitch
added
type/refactor
Contributor
|
Thanks for the careful PR hygiene, @briandevans! This automated hermes-sweeper review found that the change is already present on
The single-line addition this PR introduces was apparently merged separately (likely as part of a batch or salvage), so closing as implemented on main. No further action needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the GitHub noreply form of my email (`252620095+briandevans@users.noreply.github.com`) to `AUTHOR_MAP` in `scripts/release.py`.
`brian@bde.io` is already mapped, but commits authored against the noreply form (which is what GitHub-default `git config user.email` setups produce) fall through to unmapped in `contributor_audit` strict mode. This means any salvage of my work that picks up the noreply authorship would break the release attribution pipeline.
This PR only adds a single entry — no behavior change, no test changes, no other contributors touched. Mirrors the pattern used for kshitijk4poor in #11120 and the batch in #11076.
Verification
```
python -c "
import ast, pathlib
tree = ast.parse(pathlib.Path('scripts/release.py').read_text())
d = next(ast.literal_eval(n.value) for n in ast.walk(tree)
if isinstance(n, ast.Assign) and any(getattr(t, 'id', None) == 'AUTHOR_MAP' for t in n.targets))
assert d['252620095+briandevans@users.noreply.github.com'] == 'briandevans'
assert d['brian@bde.io'] == 'briandevans'
print(len(d)) # -> 211
"
```
No standalone lint command is defined; CI runs `python -m pytest tests/ -q --ignore=tests/integration --ignore=tests/e2e --tb=short -n auto` (matches `.github/workflows/tests.yml`). No tests reference `AUTHOR_MAP`, so no test impact.
Related Issue
No specific issue — maintenance change against the release script. The trigger was noticing that the noreply form wasn't mapped while working on salvage-friendly PR hygiene.
Type of Change
Changes Made
How to Test
Checklist
Code
Documentation & Housekeeping