Skip to content

haskell.packages.ghc881.attoparsec: fix build#67657

Closed
vaibhavsagar wants to merge 20 commits intoNixOS:haskell-updatesfrom
vaibhavsagar:ghc881-attoparsec
Closed

haskell.packages.ghc881.attoparsec: fix build#67657
vaibhavsagar wants to merge 20 commits intoNixOS:haskell-updatesfrom
vaibhavsagar:ghc881-attoparsec

Conversation

@vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Aug 28, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

rnhmjoj and others added 20 commits August 26, 2019 11:34
@rnhmjoj
magnetico: init at 0.8.1
fc4ca1a
@rnhmjoj
nixos/magnetico: init service
182830f
@rnhmjoj
nixos/magnetico: add test
ea40c66
@davidak
nixos-containers: add TimeoutStartSec option
eba686d 
Default is now 1m instead of global default of 15sec. It is also
configurable.

Fixes issue where start of many containers (40+) fail
NixOS#65001
@worldofpeace
rl-1909: add note about Xfce 4.14
722746c
@andir
dovecot-pigeonhole: 0.5.7.1 -> 0.5.7.2 (CVE-2019-11500)
46ff96c 
This is a followup on NixOS#67623
libargon2: fixed cross-compilation
06073ae 
Makefile had a hardcoded unprefixed ar. I wrote a patch (sending it
upstream) and added an optional make flag to override it in case we're
cross-compiling.

Unfortunately, this causes a rebuild of native packages.

This commit also fixes the pkg-config file to be generated correctly,
patch was provided by @worldofpeace.
@infinisil
Merge pull request NixOS#65661 from davidak/containers
fb7611a 
nixos-containers: add TimeoutStartSec option
@infinisil
Merge pull request NixOS#64738 from rnhmjoj/magnetico
6233291 
magnetico: init package and service
@worldofpeace
Merge pull request NixOS#67490 from kisik21/master
58fd72f 
libargon2: fixed cross-compilation
lr: add myself (@kisik21) as maintainer
cd7142b 
As an answer to NixOS#67638, I'm adopting this package, adding myself as a
maintainer.
@worldofpeace
Merge pull request NixOS#67626 from worldofpeace/xfce4-14-doc
b49a765 
rl-1909: add note about Xfce 4.14
@mmahut
prometheus-cups-exporter: init at unstable-2019-03-17
0c4cb4c
@grahamc
Merge pull request NixOS#67642 from kisik21/lr-maintainership
ff6b4b1 
lr: add myself (@kisik21) as maintainer
@imuli @kalbasit
fly: 5.3.0 -> 5.4.1 (NixOS#67633)
7863697
@andir
Merge pull request NixOS#67637 from andir/dovecot
f43086c 
dovecot-pigeonhole: 0.5.7.1 -> 0.5.7.2 (CVE-2019-11500)
@WilliButz
Merge pull request NixOS#67634 from mmahut/prometheus-cups-exporter
b602b5c 
prometheus-cups-exporter: init at unstable-2019-03-17
@bachp @zimbatm
nixos/gitlab-runner: add missing HOME to environment (NixOS#67450)
02ed974 
Gitlab runner fails to start if HOME is not set.
@danielfullmer @zimbatm
zerotierone: 1.4.2 -> 1.4.4 (NixOS#67648)
33b6776
haskell.packages.ghc881.attoparsec: fix build
f07eed8
@vaibhavsagar
Copy link
Member Author

vaibhavsagar commented Aug 28, 2019

This depends on #67654.

@ofborg ofborg bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 28, 2019
@cdepillabout cdepillabout mentioned this pull request Aug 29, 2019
Closed
10 tasks
@vaibhavsagar vaibhavsagar changed the base branch from master to haskell-updates August 29, 2019 16:58
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes labels Aug 29, 2019
@ofborg ofborg bot added 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.