Skip to content

nixos/gitlab-runner: add missing HOME to environment#67450

Merged
zimbatm merged 1 commit intoNixOS:masterfrom
bachp:gitlab-runner-home
Aug 28, 2019
Merged

nixos/gitlab-runner: add missing HOME to environment#67450
zimbatm merged 1 commit intoNixOS:masterfrom
bachp:gitlab-runner-home

Conversation

@bachp
Copy link
Member

@bachp bachp commented Aug 25, 2019

Motivation for this change

Gitlab runner fails to start if HOME is not set.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @max-wittig

Gitlab runner fails to start if HOME is not set.
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 25, 2019
@bachp
Copy link
Member Author

bachp commented Aug 28, 2019

/cc @zimbatm

@zimbatm zimbatm merged commit 02ed974 into NixOS:master Aug 28, 2019
@zimbatm
Copy link
Member

zimbatm commented Aug 28, 2019

was that a new issue? the previous upgrade must not have been tested properly

@bachp bachp deleted the gitlab-runner-home branch August 29, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants