Skip to content

haskell.packages.ghc881.unordered-containers: remove broken override#67650

Closed
vaibhavsagar wants to merge 1 commit intoNixOS:masterfrom
vaibhavsagar:ghc881-unordered-containers
Closed

haskell.packages.ghc881.unordered-containers: remove broken override#67650
vaibhavsagar wants to merge 1 commit intoNixOS:masterfrom
vaibhavsagar:ghc881-unordered-containers

Conversation

@vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Aug 28, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 28, 2019
@vaibhavsagar vaibhavsagar changed the title ghc881: remove broken unordered-containers override haskell.packages.ghc881.unordered-containers: remove broken override Aug 28, 2019
@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskell.packages.ghc881.unordered-containers

@cdepillabout
Copy link
Member

@vaibhavsagar Should this PR and your other recent PRs (#67651, #67653, #67654, #67655, and #67657) be based on the haskell-updates branch instead of master?

@infinisil recently left a comment explaining that any change to the configuration-*.nix files should probably go to the haskell-updates branch.

@vaibhavsagar
Copy link
Member Author

Closed in favour of #67709.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants