Skip to content

magnetico: init package and service#64738

Merged
infinisil merged 3 commits intoNixOS:masterfrom
rnhmjoj:magnetico
Aug 28, 2019
Merged

magnetico: init package and service#64738
infinisil merged 3 commits intoNixOS:masterfrom
rnhmjoj:magnetico

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jul 14, 2019 •
edited
Loading

Motivation for this change

Wanted to self-host a DHT crawler.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I have tested basically everything. the crawler works, the web ui works, also authentication.

@rnhmjoj rnhmjoj requested a review from infinisil as a code owner July 14, 2019 18:44
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package labels Jul 14, 2019
@ofborg ofborg bot requested a review from kalbasit July 14, 2019 18:58
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 14, 2019
kalbasit
kalbasit reviewed Jul 15, 2019
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed the Go package.

kalbasit
kalbasit approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the Go package only. I have not reviewed the NixOS module.

@kalbasit
Copy link
Member

kalbasit commented Jul 15, 2019

@GrahamcOfBorg build magnetico

@ofborg ofborg bot requested a review from kalbasit July 15, 2019 15:06
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 20, 2019

I disabled the build on darwin, since ofBorg says the build is failing.

tilpner
tilpner reviewed Aug 26, 2019
View reviewed changes
nixos/modules/services/networking/magnetico.nix Outdated
Copy link
Member

@tilpner tilpner Aug 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem sensible. Wouldn't this cause an arbitrary free port to be selected every time?

Copy link
Contributor Author

@rnhmjoj rnhmjoj Aug 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, it's what the software does by default. Do you think I should pick an arbitrary port?

infinisil
infinisil requested changes Aug 27, 2019
View reviewed changes
infinisil
infinisil reviewed Aug 27, 2019
View reviewed changes
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Aug 28, 2019

I added a small test.

infinisil
infinisil requested changes Aug 28, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this thing, this LGTM

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Aug 28, 2019

Should be ready.

@infinisil infinisil merged commit 6233291 into NixOS:master Aug 28, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Aug 28, 2019

Thank you all for the review.

@rnhmjoj rnhmjoj deleted the magnetico branch September 14, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@infinisil infinisil infinisil approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

+1 more reviewer

@tilpner tilpner tilpner left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rnhmjoj @kalbasit @tilpner @infinisil