Skip to content

prometheus-cups-exporter: init at unstable-2019-03-17#67634

Merged
WilliButz merged 1 commit intoNixOS:masterfrom
mmahut:prometheus-cups-exporter
Aug 28, 2019
Merged

prometheus-cups-exporter: init at unstable-2019-03-17#67634
WilliButz merged 1 commit intoNixOS:masterfrom
mmahut:prometheus-cups-exporter

Conversation

@mmahut
Copy link
Member

@mmahut mmahut commented Aug 28, 2019 •
edited
Loading

Motivation for this change

init at unstable-2019-03-17

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut mmahut requested a review from WilliButz August 28, 2019 15:54
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 28, 2019
WilliButz
WilliButz requested changes Aug 28, 2019
View reviewed changes
@mmahut mmahut force-pushed the prometheus-cups-exporter branch from 92865a7 to 0c4cb4c Compare August 28, 2019 17:56
@mmahut
Copy link
Member Author

mmahut commented Aug 28, 2019

Setting as unfree until ThoreKr/cups_exporter#2 is resolved.

WilliButz
WilliButz approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@WilliButz WilliButz merged commit b602b5c into NixOS:master Aug 28, 2019
@ThoreKr ThoreKr mentioned this pull request Mar 16, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WilliButz WilliButz WilliButz approved these changes

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmahut @WilliButz