Merged
Conversation
Member
|
it's a shame about BSL but nothing we can do about it |
Contributor
|
I just noticed the license change when updating a test system using the unstable channel. How do we usually handle such a change to an unfree license? Should this be added to the release notes that nobody is surprised that systems without |
Member
|
Good question. It's a first for me too. What happens is the user gets a breakage if allowUnfree is set to false. At that point I expect the user to look into the code. Is there anything we can do better? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update for latest version. See: https://github.com/zerotier/ZeroTierOne/releases/tag/1.4.4
Note the license change to BSL 1.1.
Tested working with my zerotier network.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @sjmackenzie @zimbatm @ehmry @obadz