nushell, nushellPlugins: 0.109.1 -> 0.110.0, move from pkgs/shells to pkgs/by-name#482961
nushell, nushellPlugins: 0.109.1 -> 0.110.0, move from pkgs/shells to pkgs/by-name#482961happysalada merged 3 commits intoNixOS:masterfrom
pkgs/shells to pkgs/by-name#482961Conversation
cb70c5f to
9a8d276
Compare
9a8d276 to
d430848
Compare
d430848 to
7510ec5
Compare
| # add two checks: | ||
| # - `versionCheckhook`, checks wether it's a binary that is able to | ||
| # display its own version | ||
| # - A check which loads the plugin into the current version of nushell, | ||
| # to detect incompatibilities (plugins are compiled for very specific | ||
| # versions of nushell). If this fails, either update the plugin or mark | ||
| # as broken. | ||
| withChecks = p.overrideAttrs ( | ||
| final: _prev: { | ||
| doInstallCheck = true; | ||
| nativeInstallCheckInputs = [ versionCheckHook ]; | ||
|
|
||
| passthru.tests.loadCheck = | ||
| let | ||
| nu = lib.getExe nushell; | ||
| plugin = lib.getExe withChecks; | ||
| in | ||
| runCommand "test-load-${final.pname}" { } '' | ||
| touch $out | ||
| ${nu} -n -c "plugin add --plugin-config $out ${plugin}" | ||
| ${nu} -n -c "plugin use --plugin-config $out ${plugin}" | ||
| ''; | ||
| } | ||
| ); | ||
| in | ||
| withChecks |
There was a problem hiding this comment.
Where would we move this checks? Would we even want to keep them?
|
If that helps us not lag behind every update I'm all for it |
b69291d to
6151c02
Compare
If this PR gets accepted as proposed right now, yes, you would need to move the file location to If some init PR will get merged before this present PR, I will amend it here. |
desktop_notifications 0.108.0 -> 0.110.0 hcl 0.108.0 -> 0.110.0 highlights 1.4.10+0.108.0 -> 1.4.12+0.110.0 semver 0.11.8 -> 0.11.10 skim 0.20.1 -> 0.22.0
6151c02 to
4bf45c1
Compare
JohnTitor
left a comment
There was a problem hiding this comment.
Thank you for taking care of it!
|
|
🎉 Thanks for the swift merge! Now 🤞 for the next version update that bot-merges will work as intended 😀 |
There was a problem hiding this comment.
Is it possible to have gstat = nushell-plugin-gstat; instead?
There was a problem hiding this comment.
Idk, I just know that callPackage either expects a default.nix when only presented a path, or explicitly point to the .nix file.
As per discussion in comment and following we want to use the opportunity of a version update to move nushell and its plugins from
pkgs/shellstopkgs/by-namein order to make the packagesmerge-bot eligiblesince the respectiv PRs already get opened by @r-ryantm.Note: #482538 attempts to gather plugins in
pkgs/sets, as this structure is intended to be the future way of handling things, but this also requires changes to the merge-bot which is unforseeable, when this might happen, so we want to do the above move first to improve on the freshness of nushell and its plugins.Updates
and the following plugins
Supersedes:
#481226
#480011
#467479
#466499
#466454
#466500
Mentioning the followng init PRs as a heads up for this upcoming change:
#484945
#484947
#420874
#420247
#420202
#350587
#350416
#343036
#254250
Note: to adjust the init PR to the here proposed structure you need to:
pkgs/shells/nushell/nushellPlugins/<plugin-name>.nixtopkgs/by-name/nu/nushell-plugin-<plugin-name>/package.nix<plugiin-name> = callPackage ../by-name/nu/nushell-plugin-<plugin-name>/package.nix { };inpkgs/top-level/all-packages.nixat thenushellPluginssection (currently at line9380)Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.