Skip to content

nushellPlugins.file: init at 0.13.0#350416

Open
mgttlinger wants to merge 1 commit intoNixOS:masterfrom
mgttlinger:file
Open

nushellPlugins.file: init at 0.13.0#350416
mgttlinger wants to merge 1 commit intoNixOS:masterfrom
mgttlinger:file

Conversation

@mgttlinger
Copy link
Copy Markdown
Member

@mgttlinger mgttlinger commented Oct 22, 2024

Things done

Added new nutshell plugin file replacing the equally named command with a nu native implementation. See https://github.com/fdncred/nu_plugin_file

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 22, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@mgttlinger mgttlinger changed the title nushellPlugins.file: init at 0.9.0 nushellPlugins.file: init at 0.11.0 Nov 22, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 23, 2024
@mgttlinger mgttlinger requested a review from aftix November 25, 2024 16:05
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 26, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
ethancedwards8
ethancedwards8 suggested changes Feb 7, 2025
View reviewed changes
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 17, 2025
@mgttlinger mgttlinger changed the title nushellPlugins.file: init at 0.11.0 nushellPlugins.file: init at 0.13.0 Feb 17, 2025
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 18, 2025
ethancedwards8
ethancedwards8 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mgttlinger
Copy link
Copy Markdown
Member Author

mgttlinger commented Feb 18, 2025

Thanks for the feedback. I'm learning something new each PR

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Feb 20, 2025
@mgttlinger
Copy link
Copy Markdown
Member Author

mgttlinger commented Mar 24, 2025

Anything missing from my side?

ethancedwards8
ethancedwards8 suggested changes Mar 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling in the Darwin SDKs may no longer be necessary.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 21, 2025
@VuiMuich VuiMuich mentioned this pull request Jan 29, 2026
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ethancedwards8 ethancedwards8 ethancedwards8 requested changes

@aftix aftix aftix approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mgttlinger @aftix @ethancedwards8 @wegank