nushellPlugins.*: automatically patch dependencies to support current nushell version by timon-schelling · Pull Request #441173 · NixOS/nixpkgs

timon-schelling · 2025-09-08T11:00:02Z

Things done

Add a 👍 reaction to pull requests you find important.

dtomvan

I know it's still a draft, but here's the things I currently find hacky: hope that helps.

pkgs/shells/nushell/plugins/default.nix

dtomvan · 2025-09-08T12:05:52Z

pkgs/shells/nushell/plugins/default.nix

Isn't this just prev.name?

prev.name is not available for some reason.

error: attribute 'name' missing at /nix/store/i2srmbli3vkrh11g5islzy5zzm1hxybs-source/pkgs/shells/nushell/plugins/default.nix:27:36: 26| (rustPlatform.fetchCargoVendor ({ 27| inherit (prev) src name; | ^ 28| hash = prev.cargoHash;

pkgs/shells/nushell/plugins/default.nix

timon-schelling · 2025-09-08T12:28:18Z

I know it's still a draft, but here's the things I currently find hacky: hope that helps.

Thanks for the comments, just wanted to test if this is possible. Didn't know about cargo-edit etc. could have saved a lot of time. I will address your comments in the next days.

timon-schelling · 2025-09-08T12:41:35Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 441173
Commit: 0dce073dc2fe0da9ead986e0398efac344a5adae (subsequent changes)
Merge: 24731286f01035a3e776f5c3d67eb46d958101ae

Logs: https://github.com/timon-schelling/run-nixpkgs-review/actions/runs/17549164161

`x86_64-linux`

✅ 12 packages built:

nushellPlugins.dbus
nushellPlugins.desktop_notifications
nushellPlugins.formats
nushellPlugins.gstat
nushellPlugins.hcl
nushellPlugins.highlight
nushellPlugins.net
nushellPlugins.polars
nushellPlugins.query
nushellPlugins.semver
nushellPlugins.skim
nushellPlugins.units

`aarch64-linux`

✅ 12 packages built:

nushellPlugins.dbus
nushellPlugins.desktop_notifications
nushellPlugins.formats
nushellPlugins.gstat
nushellPlugins.hcl
nushellPlugins.highlight
nushellPlugins.net
nushellPlugins.polars
nushellPlugins.query
nushellPlugins.semver
nushellPlugins.skim
nushellPlugins.units

timon-schelling · 2025-09-09T00:56:05Z

@dtomvan could you take another look?

… nushell version

timon-schelling · 2025-09-09T02:27:44Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 441173
Commit: e54a24c7377f4a96c78d3885c9b034f185dc5fb7 (subsequent changes)
Merge: 379c2e9d41aaad0709fed107846c6715f4054645

Logs: https://github.com/timon-schelling/run-nixpkgs-review/actions/runs/17568684242

`x86_64-linux`

❌ 1 package failed to build:

nushellPlugins.net

✅ 11 packages built:

nushellPlugins.dbus
nushellPlugins.desktop_notifications
nushellPlugins.formats
nushellPlugins.gstat
nushellPlugins.hcl
nushellPlugins.highlight
nushellPlugins.polars
nushellPlugins.query
nushellPlugins.semver
nushellPlugins.skim
nushellPlugins.units

`aarch64-linux`

❌ 1 package failed to build:

nushellPlugins.net

✅ 11 packages built:

nushellPlugins.dbus
nushellPlugins.desktop_notifications
nushellPlugins.formats
nushellPlugins.gstat
nushellPlugins.hcl
nushellPlugins.highlight
nushellPlugins.polars
nushellPlugins.query
nushellPlugins.semver
nushellPlugins.skim
nushellPlugins.units

timon-schelling · 2025-09-09T07:47:10Z

cargoHash doesn't seem to be stable now. I get 3 different hashes at 3 different times. I suspect that cargo edit isn't deterministic and can lock different downstream crate versions dependent on the time they are fetched.

I'm not sure if the same problem exits with my earlier approach.

dtomvan

That's unfortunate. This looks much better to me though.

dtomvan · 2025-09-09T15:45:16Z

pkgs/shells/nushell/plugins/default.nix

+                postBuild = ''
+                  if ! [ -z "''${NUSHELL_VERSION_UPGRADED}" ]; then
+                    cp Cargo.toml $out/Cargo.toml
+                  fi
+                '';
+              })).overrideAttrs
+                (old: {
+                  buildCommand = old.buildCommand + ''
+                    cp $vendorStaging/Cargo.toml $out/Cargo.toml || true
+                  '';
+                });
+
+            postPatch = ''
+              cp ${final.cargoDeps}/Cargo.lock ./Cargo.lock
+              cp ${final.cargoDeps}/Cargo.toml ./Cargo.toml || true
+            '';


Why would we have to conditionally copy cargo.toml? In this case it may silently continue after failing to copy Cargo.toml (however that may happen)

dtomvan · 2025-09-09T15:59:48Z

pkgs/shells/nushell/plugins/default.nix

+                  if is_compatible nu-plugin "${nushell.version}"; then
+                    echo "nu-plugin is compatible, no patching needed"
+                  else
+                    cargo upgrade -p nu-plugin@${nushell.version} -p nu-protocol@${nushell.version}


You might be able to pin the exact version with an =-sign before the version. https://docs.rs/semver/latest/semver/enum.Op.html

Also, if you want to debug the reproducibility of this, you can probably use -v and CARGO_LOG=upgrade=trace to figure out what cargo commands it's calling under the hood and what versions it's selecting. cargo itself isn't that deterministic in and of itself though...

VuiMuich · 2026-01-31T17:14:38Z

Is this patch still relevant after nushell plugins becoming merge-bot eligible through #482961?

dtomvan · 2026-01-31T22:58:01Z

I'd say yes, since some plugins' upstreams are very, very slow with updating. I have two PRs open for 7 months now:

nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Sep 8, 2025

timon-schelling force-pushed the nushell-plugins-autopatch-nushell-version branch from e3c9044 to 0dce073 Compare September 8, 2025 11:23

timon-schelling mentioned this pull request Sep 8, 2025

nushell: 0.106.1 -> 0.107.0, nushellPlugins.*: update #439871

Merged

13 tasks

dtomvan self-requested a review September 8, 2025 11:40

dtomvan reviewed Sep 8, 2025

View reviewed changes

timon-schelling force-pushed the nushell-plugins-autopatch-nushell-version branch from 0dce073 to 6380f3d Compare September 9, 2025 00:46

timon-schelling requested a review from dtomvan September 9, 2025 01:03

timon-schelling added 2 commits September 9, 2025 01:10

nushellPlugins.*: automatically patch dependencies to support current…

16e2b52

… nushell version

nushellPlugins.*: remove broken status

e54a24c

timon-schelling force-pushed the nushell-plugins-autopatch-nushell-version branch from 6380f3d to e54a24c Compare September 9, 2025 01:11

dtomvan reviewed Sep 9, 2025

View reviewed changes

nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 31, 2026

Uh oh!

Conversation

timon-schelling commented Sep 8, 2025

Things done

Uh oh!

dtomvan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dtomvan Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

timon-schelling Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timon-schelling commented Sep 8, 2025

Uh oh!

timon-schelling commented Sep 8, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

Uh oh!

timon-schelling commented Sep 9, 2025

Uh oh!

timon-schelling commented Sep 9, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

Uh oh!

timon-schelling commented Sep 9, 2025

Uh oh!

dtomvan left a comment

Choose a reason for hiding this comment

Uh oh!

dtomvan Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

dtomvan Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

VuiMuich commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dtomvan commented Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

VuiMuich commented Jan 31, 2026 •

edited

Loading