Skip to content

nushellPlugins.file: init at 0.16.0#420247

Draft
timon-schelling wants to merge 1 commit intoNixOS:masterfrom
timon-schelling:init-nushellPlugins-file
Draft

nushellPlugins.file: init at 0.16.0#420247
timon-schelling wants to merge 1 commit intoNixOS:masterfrom
timon-schelling:init-nushellPlugins-file

Conversation

@timon-schelling
Copy link
Copy Markdown
Member

https://github.com/fdncred/nu_plugin_file

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 26, 2025
Copy link
Copy Markdown
Contributor

@dtomvan dtomvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, tests, and seems to be able to identify itself. I'll call that a success 👍

$ file ./result/bin/nu_plugin_file | to json
{
  "description": "elf64 binary, x86_64",
  "format": "Executable",
  "magics": [
    {
      "offset": 0,
      "length": 4,
      "bytes": [
        127,
        69,
        76,
        70
      ]
    }
  ],
  "details": {
    "arch": "x86_64",
    "format": "elf64",
    "dependencies": [
      "libgcc_s.so.1",
      "libc.so.6"
    ]
  }
}

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 27, 2025
@timon-schelling timon-schelling force-pushed the init-nushellPlugins-file branch from 9a52f74 to 058a207 Compare June 27, 2025 22:42
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 30, 2025
@timon-schelling timon-schelling marked this pull request as draft July 2, 2025 10:18
@timon-schelling timon-schelling force-pushed the init-nushellPlugins-file branch from 058a207 to 6901f61 Compare July 2, 2025 10:20
@timon-schelling timon-schelling marked this pull request as ready for review July 2, 2025 10:20
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 2, 2025
@timon-schelling
Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 420247

Logs: https://github.com/timon-schelling/run-nixpkgs-review/actions/runs/16022519408


x86_64-linux (sandbox = true)

✅ 1 package built:
  • nushellPlugins.file

aarch64-linux (sandbox = true)

✅ 1 package built:
  • nushellPlugins.file

@dtomvan
Copy link
Copy Markdown
Contributor

dtomvan commented Jul 2, 2025

Still LGTM. I assume this PR still works after my refactor/checks added?

@timon-schelling
Copy link
Copy Markdown
Member Author

Yeah, the only real change is the removal of the duplicated loadCheck test (the one you added for all plugins).

@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5728

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 27, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 29, 2026
@timon-schelling timon-schelling marked this pull request as draft February 9, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants