nushellPlugins.file: init at 0.16.0#420247
Draft
timon-schelling wants to merge 1 commit intoNixOS:masterfrom
Draft
nushellPlugins.file: init at 0.16.0#420247timon-schelling wants to merge 1 commit intoNixOS:masterfrom
timon-schelling wants to merge 1 commit intoNixOS:masterfrom
Conversation
dtomvan
approved these changes
Jun 27, 2025
Contributor
dtomvan
left a comment
There was a problem hiding this comment.
Builds, tests, and seems to be able to identify itself. I'll call that a success 👍
$ file ./result/bin/nu_plugin_file | to json
{
"description": "elf64 binary, x86_64",
"format": "Executable",
"magics": [
{
"offset": 0,
"length": 4,
"bytes": [
127,
69,
76,
70
]
}
],
"details": {
"arch": "x86_64",
"format": "elf64",
"dependencies": [
"libgcc_s.so.1",
"libc.so.6"
]
}
}9a52f74 to
058a207
Compare
058a207 to
6901f61
Compare
Member
Author
|
Contributor
|
Still LGTM. I assume this PR still works after my refactor/checks added? |
Member
Author
|
Yeah, the only real change is the removal of the duplicated loadCheck test (the one you added for all plugins). |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5728 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/fdncred/nu_plugin_file
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.