Skip to content

nushellPlugins.hcl: 0.108.0 -> 0.110.0#467479

Closed
Yethal wants to merge 1 commit intoNixOS:masterfrom
Yethal:update-nushellplugin-hcl
Closed

nushellPlugins.hcl: 0.108.0 -> 0.110.0#467479
Yethal wants to merge 1 commit intoNixOS:masterfrom
Yethal:update-nushellplugin-hcl

Conversation

@Yethal
Copy link
Copy Markdown
Contributor

@Yethal Yethal commented Dec 3, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Dec 3, 2025
@Yethal Yethal requested a review from JohnTitor December 3, 2025 13:22
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Dec 3, 2025
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Dec 8, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/6144

@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Dec 17, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2696

@seh
Copy link
Copy Markdown

seh commented Jan 5, 2026

I just ran into this problem, having picked up on the recent #467152 that upgraded nushell to version 0.109.1, leaving this plugin out of date.

@Yethal
Copy link
Copy Markdown
Contributor Author

Yethal commented Jan 5, 2026 •
edited
Loading

I just ran into this problem, having picked up on the recent #467152 that upgraded nushell to version 0.109.1, leaving this plugin out of date.

I know, I'm still waiting for an approval on this

@seh
Copy link
Copy Markdown

seh commented Jan 6, 2026

I'm still waiting for approval on this

Given that you're the only maintainer cited in the package's source file, how do you figure out who else is fit to review and approve this patch?

@Yethal
Copy link
Copy Markdown
Contributor Author

Yethal commented Jan 6, 2026

I'm still waiting for approval on this

Given that you're the only maintainer cited in the package's source file, how do you figure out who else is fit to review and approve this patch?

I ask one of he maintainers of nushell proper

@koffydrop
Copy link
Copy Markdown
Contributor

koffydrop commented Jan 11, 2026

I wonder if it would be possible to have something like the merge bot for nushell plugins as they get stuck out of sync fairly often waiting for maintainers/approvals

@seh
Copy link
Copy Markdown

seh commented Jan 15, 2026

Yes, there doesn't appear to be anything controversial about this patch. Is @JohnTitor the only person who can approve this? Perhaps @VuiMuich or @dtomvan could take a look.

@Yethal Yethal requested a review from VuiMuich January 15, 2026 22:43
@VuiMuich
Copy link
Copy Markdown
Contributor

VuiMuich commented Jan 16, 2026

I'll run a build test asap and reading the diff all is lgtm.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 16, 2026
@VuiMuich
Copy link
Copy Markdown
Contributor

VuiMuich commented Jan 16, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 467479
Commit: b5feeeaa298fd25ef5b8f968b546635b8eed3097

x86_64-linux

✅ 1 package built:
  • nushellPlugins.hcl

JohnTitor
JohnTitor approved these changes Jan 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, LGTM.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 16, 2026
@VuiMuich
Copy link
Copy Markdown
Contributor

VuiMuich commented Jan 21, 2026

Would this be ready to be bumped to 0.110.0 immediately, or needs the plugin upstream a release before?

@Yethal
Copy link
Copy Markdown
Contributor Author

Yethal commented Jan 21, 2026

I can bump it immediately

@Yethal Yethal force-pushed the update-nushellplugin-hcl branch from b5feeea to 8fc144f Compare January 21, 2026 19:18
@Yethal Yethal changed the title nushellPlugins.hcl: 0.108.0 -> 0.109.1 nushellPlugins.hcl: 0.108.0 -> 0.110.0 Jan 21, 2026
@Yethal
Copy link
Copy Markdown
Contributor Author

Yethal commented Jan 21, 2026

@VuiMuich done

@VuiMuich
Copy link
Copy Markdown
Contributor

VuiMuich commented Jan 22, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 467479
Commit: 8fc144f80a89ee64eaf0d426a8caeae87bf45d5b

x86_64-linux

✅ 1 package built:
  • nushellPlugins.hcl

@VuiMuich VuiMuich mentioned this pull request Jan 23, 2026
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 8.has: package (update) This PR updates a package to a newer version label Jan 27, 2026
@VuiMuich
Copy link
Copy Markdown
Contributor

VuiMuich commented Jan 30, 2026

superseded by #482961

@VuiMuich VuiMuich closed this Jan 30, 2026
@Yethal Yethal deleted the update-nushellplugin-hcl branch January 30, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@VuiMuich VuiMuich VuiMuich approved these changes

@JohnTitor JohnTitor JohnTitor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Yethal @nixos-discourse @seh @koffydrop @VuiMuich @JohnTitor