Skip to content

nushellPlugins.plot: init at 0.103.0-unstable-2025-06-11#420202

Draft
timon-schelling wants to merge 1 commit intoNixOS:masterfrom
timon-schelling:init-nushellPlugins-plot
Draft

nushellPlugins.plot: init at 0.103.0-unstable-2025-06-11#420202
timon-schelling wants to merge 1 commit intoNixOS:masterfrom
timon-schelling:init-nushellPlugins-plot

Conversation

@timon-schelling
Copy link
Copy Markdown
Member

https://github.com/Euphrasiologist/nu_plugin_plot

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 26, 2025
Copy link
Copy Markdown
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, hello. A couple of notes

@timon-schelling timon-schelling force-pushed the init-nushellPlugins-plot branch from baec579 to 4371483 Compare June 26, 2025 12:04
@timon-schelling
Copy link
Copy Markdown
Member Author

Thanks @acid-bong

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Jun 26, 2025
@timon-schelling timon-schelling force-pushed the init-nushellPlugins-plot branch from 4371483 to dd8caf3 Compare June 26, 2025 12:25
@timon-schelling timon-schelling changed the title nushellPlugins.plot: init at 0-unstable-2025-06-11 nushellPlugins.plot: init at 0.103.0-unstable-2025-06-11 Jun 26, 2025
Copy link
Copy Markdown
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code. Good luck nixing

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 26, 2025
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5611

@timon-schelling timon-schelling force-pushed the init-nushellPlugins-plot branch from dd8caf3 to 78a0446 Compare June 27, 2025 22:47
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 30, 2025
@timon-schelling timon-schelling marked this pull request as draft July 2, 2025 10:29
@timon-schelling timon-schelling force-pushed the init-nushellPlugins-plot branch from 78a0446 to a0b0890 Compare July 2, 2025 10:29
@timon-schelling timon-schelling marked this pull request as ready for review July 2, 2025 10:30
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 2, 2025
@timon-schelling
Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 420202

Logs: https://github.com/timon-schelling/run-nixpkgs-review/actions/runs/16022726830


x86_64-linux (sandbox = true)

❌ 1 package failed to build:
  • nushellPlugins.plot

Error logs: `x86_64-linux`
nushellPlugins.plot
Command: xyplot
Description:
 > Render an ASCII xy plot from a list of values.

Flags:
-h, --help: Display the help message for this command
--width : The maximum width of the plot.
--height : The maximum height of the plot.
-t, --title : Provide a title to the plot.
-l, --legend: Plot a tiny, maybe useful legend.
-b, --bars: Change lines to bars.
-s, --steps: Change lines to steps.
-p, --points: Change lines to points.

Parameters:

Did not find version 0.103.0-unstable-2025-06-11 in the output of the command /nix/store/fb46flxjai07hh1lva2xdz0v79nbdinr-nu_plugin_plot-0.103.0-unstable-2025-06-11/bin/nu_plugin_plot --version
{{storeDir}}/bin/nu_plugin_plot: This plugin must be run from within Nushell. See plugin add --help for details on how to use plugins.
If you are running from Nushell, this plugin may be incompatible with the version of nushell you are using.


aarch64-linux (sandbox = true)

❌ 1 package failed to build:
  • nushellPlugins.plot

Error logs: `aarch64-linux`
nushellPlugins.plot
Command: xyplot
Description:
 > Render an ASCII xy plot from a list of values.

Flags:
-h, --help: Display the help message for this command
--width : The maximum width of the plot.
--height : The maximum height of the plot.
-t, --title : Provide a title to the plot.
-l, --legend: Plot a tiny, maybe useful legend.
-b, --bars: Change lines to bars.
-s, --steps: Change lines to steps.
-p, --points: Change lines to points.

Parameters:

Did not find version 0.103.0-unstable-2025-06-11 in the output of the command /nix/store/k0cjyj7sn036jn96vbmhwgz32sq77jvr-nu_plugin_plot-0.103.0-unstable-2025-06-11/bin/nu_plugin_plot --version
{{storeDir}}/bin/nu_plugin_plot: This plugin must be run from within Nushell. See plugin add --help for details on how to use plugins.
If you are running from Nushell, this plugin may be incompatible with the version of nushell you are using.

@timon-schelling timon-schelling force-pushed the init-nushellPlugins-plot branch from a0b0890 to 49f5a9e Compare July 2, 2025 11:51
@timon-schelling
Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 420202

Logs: https://github.com/timon-schelling/run-nixpkgs-review/actions/runs/16024331435


x86_64-linux (sandbox = true)

✅ 1 package built:
  • nushellPlugins.plot

aarch64-linux (sandbox = true)

✅ 1 package built:
  • nushellPlugins.plot

@timon-schelling timon-schelling marked this pull request as draft July 2, 2025 16:52
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 27, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants