[25.05] ente-desktop: 1.7.11 -> 1.7.14

[teutat3s]

Manual backports of #427695, #442605

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[ToasterUwU]

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 447316
Commit: 1d3002d9336da6fd4b4b370deb15ca660000cf3f (subsequent changes)
Merge: 0131594a5cbc23a7e75b53e8e718efe4dd88b483

Logs: https://github.com/ToasterUwU/nixpkgs-review-gha/actions/runs/18116851287

---

x86_64-linux

✅ 1 package built:

• ente-desktop

---

aarch64-linux

✅ 1 package built:

• ente-desktop

---

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:

• ente-desktop

---

Error logs: `x86_64-darwin`

ente-desktop

WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
cp: missing destination file operand after '/nix/store/0mjaag6z3jbgqh1j6i5pzkwm0hf29j5v-ente-desktop-1.7.14/share/ente-desktop'

Try 'cp --help' for more information.

---

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:

• ente-desktop

---

Error logs: `aarch64-darwin`

ente-desktop

  • loaded configuration  file=/nix/build/nix-16938-3880056461/source/desktop/electron-builder.yml
  • writing effective config  file=dist/builder-effective-config.yaml
  • executing @electron/rebuild  electronVersion=37.5.1 arch=arm64 buildFromSource=false appDir=./
  • installing native dependencies  arch=arm64
  • completed installing native dependencies
  • packaging       platform=darwin arch=arm64 electron=37.5.1 appOutDir=dist/mac-arm64
  • custom electronDist provided but no zip found; assuming unpacked electron directory.  electronDist=electron_dist expectedFile=electron-v37.5.1-darwin-arm64.zip
  • copying Electron  source=/nix/build/nix-16938-3880056461/source/desktop/electron_dist/Electron.app destination=/nix/build/nix-16938-3880056461/source/desktop/dist/mac-arm64/Electron.app
  • falling back to ad-hoc signature for macOS application code signing
  • signing         file=dist/mac-arm64/ente.app platform=darwin type=distribution identityName=- identityHash=none provisioningProfile=none
  • Above command failed, retrying 3 more times
  • Above command failed, retrying 3 more times
  • Above command failed, retrying 3 more times
  • Above command failed, retrying 3 more times
  ⨯ spawn codesign ENOENT  failedTask=build stackTrace=Error: spawn codesign ENOENT
    at Process.ChildProcess._handle.onexit (node:internal/child_process:285:19)
    at onErrorNT (node:internal/child_process:483:16)
    at processTicksAndRejections (node:internal/process/task_queues:90:21)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[ToasterUwU]

Seems like darwin build is broken, something with "cp" seems to resolve to an empty string and make "cp" think it wasnt given a second argument.

Not familiar enough with this to know more, just pointing it out.

[yuyuyureka]

"The darwin build is broken" or "This breaks the darwin build"? - there is a difference

[ToasterUwU]

@yuyuyureka I was very confused by your comment.

Yeah im aware there is a difference, like probably most people would be, but im not familiar with the history of the package or the package itself, like i mentioned above. So i dont know if it was already broken for a long time, or if this backport broke it.

Seems like you know more about that than i do: #427695 (comment)

So assuming this is known and accepted as is, i dont really understand what the comment you send is supposed to tell me or others, seems pretty irrelevant to the comment i wrote and this discussion, unless im misunderstanding something.

Sorry in advance if im just misunderstanding, i dont mean to start anything, but without more context for the intention behind it, the only way i can read that comment in my head and actually make the words mean something, is as a snarky response to me trying to offer a bit of help. Could just be that text is text and im misunderstanding, or that im too tired to come up with another way to interpret it, or literally anything else.

Sidenote: Shouldnt the build be fixed or if not possible the support for darwin be removed? Not sure what the policy on that kind of stuff is. I know marking something as broken is a thing, but im unsure if thats usable for a platform or just the entire package as a whole.
Either way, not my place to decide and not my place to consider either honestly. I just saw this backport, saw it had no build log for all available platforms, so i wanted to help by providing one.

[yuyuyureka]

Let me re-phrase it: Could you please test if the previous version of this package does or doesn't build on darwin?

If the version without/before this PR does build, there is something wrong being introduced in this PR and it should be fixed before the PR is merged.

If it doesn't build, there is still something wrong but it doesn't have anything to do with this PR and shouldn't block it.

[ToasterUwU]

Ahhh that makes a lot more sense, thanks for the clarification, i will run the same thing over the previous version without the changes included in this backport.

[ToasterUwU]

I started a CI job for each PR that touches this package, including the init one.

Since they are old and its peak automatic CI time and this is on Darwin, this will take a while. So im gonna go to bed, let this run and hope it doesnt fail for some reason. If it does i will report back after sleep.

1.7.11 Update: https://github.com/ToasterUwU/nixpkgs-review-gha/actions/runs/18122942108
fix literal inclusion of '$out': https://github.com/ToasterUwU/nixpkgs-review-gha/actions/runs/18122876146
fix tray icon: https://github.com/ToasterUwU/nixpkgs-review-gha/actions/runs/18122891296
init at 1.7.10: https://github.com/ToasterUwU/nixpkgs-review-gha/actions/runs/18122930408

This way you can check progress yourself if you want while i sleep.

[teutat3s]

Maybe needs something like this commit to fix the error? aee7acd

[ToasterUwU]

OK, just checked the logs after waking up. Seems like this package never worked on Darwin. So this backport can go ahead, but there needs to be a separate issue or PR about the Darwin build failure

[yuyuyureka]

@ToasterUwU thanks for checking