Skip to content

[25.05] shogihome: 1.22.1 -> 1.25.0#447475

Merged
pyrox0 merged 10 commits intoNixOS:release-25.05from
teutat3s:shogihome-backports
Sep 30, 2025
Merged

[25.05] shogihome: 1.22.1 -> 1.25.0#447475
pyrox0 merged 10 commits intoNixOS:release-25.05from
teutat3s:shogihome-backports

Conversation

@teutat3s
Copy link
Member

Manual backports of shogihome updates, to bump the electron version, because electron_35 is EOL. See: #445467

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

kachick and others added 10 commits September 30, 2025 15:00
Diff: sunfish-shogi/shogihome@v1.22.1...v1.23.0

This patch was created using the following steps:

1. Removed outdated patch that was released in 1.23.0.
2. `nix-shell --pure maintainers/scripts/update.nix --argstr package shogihome`
3. Added a workaround to replace `process.resourcesPath`, it is required since this version:
  sunfish-shogi/shogihome@161891d
  Without this replacement, the shogi board background image will not be displayed.

(cherry picked from commit d2358d7)
(cherry picked from commit c73df24)
(cherry picked from commit 080d774)
(cherry picked from commit 75079ff)
(cherry picked from commit ddda942)
Darwin build only fails on sandbox mode.
This patch is taken from podman-desktop package.
See a1fcfb6 for detail

(cherry picked from commit 540c54a)
d2358d7 was regression for darwin

(cherry picked from commit 3a6dd56)
(cherry picked from commit 62d44f3)
(cherry picked from commit 9417dec)
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 4.workflow: backport This targets a stable branch labels Sep 30, 2025
@nix-owners nix-owners bot requested a review from kachick September 30, 2025 13:07
Copy link
Member

@kachick kachick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! I understand this PR contains everything from master branch except for the cherry-pick of c00a908.

nix run github:teutat3s/nixpkgs/shogihome-backports#shogihome

Image

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 447475
Commit: 1621b87d5cb29ffa8e2560fbfee08d6619fb5d84


x86_64-linux

✅ 1 package built:
  • shogihome

aarch64-linux

✅ 1 package built:
  • shogihome

x86_64-darwin

✅ 1 package built:
  • shogihome

aarch64-darwin

✅ 1 package built:
  • shogihome

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 30, 2025
@pyrox0 pyrox0 added this pull request to the merge queue Sep 30, 2025
Merged via the queue into NixOS:release-25.05 with commit f0c28d5 Sep 30, 2025
36 of 38 checks passed
@teutat3s teutat3s deleted the shogihome-backports branch September 30, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants