python3Packages.torch: Disable duplicate openmp inclusion#424873
Merged
NickCao merged 8 commits intoNixOS:masterfrom Aug 1, 2025
Merged
python3Packages.torch: Disable duplicate openmp inclusion#424873NickCao merged 8 commits intoNixOS:masterfrom
NickCao merged 8 commits intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 501+
nix-owners
bot
requested review from
GaetanLepage,
teh,
thoughtpolice and
tscholak
This was referenced Jul 13, 2025
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
This comment was marked as outdated.
This comment was marked as outdated.
sarahec
force-pushed
the
torch-segfault-bug
branch
from
8a1093f to
cb5324e
Compare
This was referenced Jul 16, 2025
sarahec
force-pushed
the
torch-segfault-bug
branch
2 times, most recently
from
da42033 to
ec53a40
Compare
This comment was marked as outdated.
This comment was marked as outdated.
sarahec
force-pushed
the
torch-segfault-bug
branch
3 times, most recently
from
c899fd3 to
a7230eb
Compare
13 tasks
apparent intel build failure was triggered when building under Rosetta due to torch ARM issue.
… Darwin Tests cannot find numpy.float128 as it's not supported on 64-bit Darwin.
… Darwin Depends on optional osascript app which isn't in nixpkgs.
sarahec
force-pushed
the
torch-segfault-bug
branch
from
a7230eb to
73f686d
Compare
These throw IPv6 network errors and/or hang until timed out.
Contributor
Author
|
Contributor
Author
|
Broken packages in review:
|
Contributor
Author
|
@reckenrode and @GaetanLepage This is ready for review. |
nix-owners
bot
requested review from
bengsparks,
dit7ya,
jherland,
natsukium and
veprbl
Contributor
Author
|
jherland
approved these changes
Jul 30, 2025
Contributor
jherland
left a comment
jherland
left a comment
There was a problem hiding this comment.
optuna-dashboard parts lgtm.
nixpkgs-ci
bot
added
12.approvals: 1
GaetanLepage
approved these changes
Jul 31, 2025
Contributor
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the thorough investigation!
nixpkgs-ci
bot
added
12.approvals: 2
Contributor
Author
|
@Aleksanaa Please take a look |
NickCao
approved these changes
Aug 1, 2025
| ]; | ||
|
|
||
| disabledTests = lib.optionals stdenv.hostPlatform.isDarwin [ | ||
| # AttributeError: module 'numpy' has no attribute 'float128' ==> not available on 64-bit Darwin |
Member
There was a problem hiding this comment.
Out of curiosity: are there non 64-bit darwin in the wild?
Contributor
Author
There was a problem hiding this comment.
Ah, I mentioned "64-bit" to make it explicit that 64 != 128
Contributor
Author
|
Thank you @NickCao |
3 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, several packages that depended on torch (directly or indirectly) began to segfault during the check phase on Darwin. Bisecting found that this began with the last torch update.
The Darwin crash logs showed a failure while calling
libopenmp.dylib(OpenMP). Randy Eckenrode identified this as an issue with pytorch and FAISS on ARM (pytorch/pytorch#149201), later refined as happening when there are two copies of OpenMP in use.Changes made
llvmPackages.openmpto the build inputs. (This turned out to be a duplicate copy.) This only affects Darwin.python3Packages.optuna-dashboardthat were masked by a segfault.python3Packages.compressai,python3Packages.pylance, andpython3Packages.torcheval.Fixes #423831
Things done
sandbox=falsefor nixpkgs-reviewnix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.