python3Packages.xgrammar: add aarch64-darwin support#424179
Closed
ferrine wants to merge 1 commit intoNixOS:masterfrom
Closed
python3Packages.xgrammar: add aarch64-darwin support#424179ferrine wants to merge 1 commit intoNixOS:masterfrom
ferrine wants to merge 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
6.topic: python
Contributor
|
Rename the PR according to conventions |
ferrine
changed the title
4 tasks
Contributor
Author
|
sarahec
suggested changes
Jul 16, 2025
Contributor
sarahec
left a comment
sarahec
left a comment
There was a problem hiding this comment.
Please remove mlx-lm from this PR since you have a proper PR waiting for it.
Contributor
|
Needed to complete |
ferrine
commented
Jul 18, 2025
Contributor
Author
There was a problem hiding this comment.
but there is one more line with a package, the ; is not needed
nixpkgs-ci
bot
added
the
2.status: merge conflict
Contributor
|
#424177 merged, shall we rebase this over current master? |
Contributor
|
This is showing up in |
Contributor
Author
|
will do soon |
13 tasks
nixpkgs-ci
bot
removed
the
2.status: merge conflict
Contributor
|
Needs a reformat tho |
Contributor
Author
|
looks like I had an outdated nixfmt |
Aleksanaa
reviewed
Aug 2, 2025
ferrine
force-pushed
the
xgrammar
branch
2 times, most recently
from
ecd1634 to
4d2256c
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Contributor
Author
|
Contributor
|
Contributor
|
@Aleksanaa can you take one more look? Thanks. |
Contributor
|
Looks OK to me, but I want someone with more Darwin on Nix experience. |
sarahec
approved these changes
Aug 20, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
13 tasks
emilazy
requested changes
Aug 30, 2025
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
nixpkgs-ci
bot
added
12.approvals: 2
nixpkgs-ci
bot
added
the
2.status: merge conflict
Contributor
Author
|
just rebased, any other changes needed to go ahead? |
nixpkgs-ci
bot
removed
the
2.status: merge conflict
Update pkgs/development/python-modules/xgrammar/default.nix Co-authored-by: Sarah Clark <seclark@nextquestion.net>
Contributor
|
It looks like other PRs have fixed xgrammar on Darwin (x86_64 and aarch64) and this can be closed. See #441270 |
Contributor
Author
|
Great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #424177, will rebase after that one merged
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.