Skip to content

python3Packages.optuna-dashboard: temporarily disable tests on Darwin#426193

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
sarahec:optuna-dashboard-notest
Jul 19, 2025
Merged

python3Packages.optuna-dashboard: temporarily disable tests on Darwin#426193
GaetanLepage merged 1 commit intoNixOS:masterfrom
sarahec:optuna-dashboard-notest

Conversation

@sarahec
Copy link
Contributor

@sarahec sarahec commented Jul 17, 2025

Disables testing on Darwin temporarily

Testing hangs on Darwin due to a torch issue on aarch64. This is fixed in #424873 (pending), but for the momentt it's blocking nixpkgs-review.

Will revert in #424873

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be c ommitted, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@sarahec
Copy link
Contributor Author

sarahec commented Jul 17, 2025

Also blocking review on #409698

@sarahec sarahec requested review from GaetanLepage and jherland July 17, 2025 19:55
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 17, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. labels Jul 17, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 18, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 19, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 426193

Logs: https://github.com/GaetanLepage/nixpkgs-review-gha/actions/runs/16389963972


x86_64-darwin (sandbox = true)

✅ 4 packages built:
  • python312Packages.optuna-dashboard
  • python312Packages.optuna-dashboard.dist
  • python313Packages.optuna-dashboard
  • python313Packages.optuna-dashboard.dist

aarch64-darwin (sandbox = true)

✅ 4 packages built:
  • python312Packages.optuna-dashboard
  • python312Packages.optuna-dashboard.dist
  • python313Packages.optuna-dashboard
  • python313Packages.optuna-dashboard.dist

@GaetanLepage GaetanLepage merged commit 0af37d3 into NixOS:master Jul 19, 2025
32 of 34 checks passed
@sarahec sarahec deleted the optuna-dashboard-notest branch July 19, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants