readstat: fix build failure by sarahec · Pull Request #425879 · NixOS/nixpkgs

sarahec · 2025-07-16T19:09:47Z

Build failure in Hydra https://hydra.nixos.org/eval/1816863?filter=readstat&compare=1816860&full=

libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
autoreconf: configure.ac: not using Intltool
autoreconf: configure.ac: not using Gtkdoc
autoreconf: running: aclocal --force
configure.ac:43: warning: macro 'AM_ICONV' not found in library
autoreconf: running: /nix/store/lsy7k7f43r9kwpgjh70siy1l15kv1jds-autoconf-2.72/bin/autoconf --force
configure.ac:43: error: possibly undefined macro: AM_ICONV
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
autoreconf: error: /nix/store/lsy7k7f43r9kwpgjh70siy1l15kv1jds-autoconf-2.72/bin/autoconf failed with exit status: 1

gettext 0.25 has been breaking older autoconf setups. Turns out we don't need it, it was there to supply iconv() which the app isn't using.

Changes

File upstream bug and patch. Apply patch.
Fix invocation of autoreconf to find m4

Things done

Add a 👍 reaction to pull requests you find important.

sarahec · 2025-07-16T19:43:52Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 425879
Commit: 640f8b0b2eb88296446d4722568b8408a48cdaa1

`aarch64-darwin`

❌ 4 packages failed to build:

python312Packages.pandera
python312Packages.pandera.dist
python313Packages.pandera
python313Packages.pandera.dist

✅ 32 packages built:

python312Packages.layoutparser
python312Packages.layoutparser.dist
python312Packages.mlcroissant
python312Packages.mlcroissant.dist
python312Packages.pandantic
python312Packages.pandantic.dist
python312Packages.pandas-stubs
python312Packages.pandas-stubs.dist
python312Packages.pdfplumber
python312Packages.pdfplumber.dist
python312Packages.pyreadstat
python312Packages.pyreadstat.dist
python312Packages.unstructured-inference
python312Packages.unstructured-inference.dist
python313Packages.layoutparser
python313Packages.layoutparser.dist
python313Packages.mlcroissant
python313Packages.mlcroissant.dist
python313Packages.pandantic
python313Packages.pandantic.dist
python313Packages.pandas-stubs
python313Packages.pandas-stubs.dist
python313Packages.pdfplumber
python313Packages.pdfplumber.dist
python313Packages.pyreadstat
python313Packages.pyreadstat.dist
python313Packages.unstructured-inference
python313Packages.unstructured-inference.dist
readstat
tocpdf
tocpdf.dist
unstructured-api

Error logs: `aarch64-darwin`

python312Packages.pandera

tests/strategies/test_strategies.py: 24 warnings
  /private/tmp/nix-build-python3.12-pandera-0.24.0.drv-0/source/tests/strategies/test_strategies.py:900: FutureWarning: DataFrame.applymap has been deprecated. Use DataFrame.map instead.
    return pandas_obj.applymap(lambda x: min_val <= x <= max_val)
tests/strategies/test_strategies.py: 30 warnings

/private/tmp/nix-build-python3.12-pandera-0.24.0.drv-0/source/pandera/strategies/pandas_strategies.py:1021: UserWarning: Dataframe check doesn't have a defined strategy. Falling back to filtering drawn values based on the check definition. This can considerably slow down data-generation.

warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

=========================== short test summary info ============================

FAILED tests/polars/test_polars_dtypes.py::test_polars_nested_dtypes_try_coercion[coercible_dtype3-noncoercible_dtype3-data3] - assert False

where False = equals(shape: (1, 1)\n┌─────────────────┐\n│ 0               │\n│ ---             │\n│ list[str]       │\n╞═════════════════╡\n│ ["a", "b", "c"] │\n└─────────────────┘)
where equals = shape: (0, 1)\n┌───────────┐\n│ 0         │\n│ ---       │\n│ list[str] │\n╞═══════════╡\n└───────────┘.equals

 where shape: (0, 1)\n┌───────────┐\n│ 0         │\n│ ---       │\n│ list[str] │\n╞═══════════╡\n└───────────┘ = select(<Expr ['col("0")'] at 0x3534947D0>)



   where select = shape: (0, 2)\n┌───────────┬──────────────┐\n│ 0         ┆ check_output │\n│ ---       ┆ ---          │\n│ list[str] ┆ bool         │\n╞═══════════╪══════════════╡\n└───────────┴──────────────┘.select



     where shape: (0, 2)\n┌───────────┬──────────────┐\n│ 0         ┆ check_output │\n│ ---       ┆ ---          │\n│ list[str] ┆ bool         │\n╞═══════════╪══════════════╡\n└───────────┴──────────────┘ = ParserError("Could not coerce  LazyFrame with schema Schema({'0': List(String)}) into type List(Int64)").failure_cases


and   shape: (1, 1)\n┌─────────────────┐\n│ 0               │\n│ ---             │\n│ list[str]       │\n╞═════════════════╡\n│ ["a", "b", "c"] │\n└─────────────────┘ = collect()

 where collect = <LazyFrame at 0x3511D8050>.collect



= 1 failed, 3391 passed, 47 skipped, 12 deselected, 8 xfailed, 7629 warnings in 126.15s (0:02:06) =

python313Packages.pandera

tests/strategies/test_strategies.py: 24 warnings
  /private/tmp/nix-build-python3.13-pandera-0.24.0.drv-0/source/tests/strategies/test_strategies.py:900: FutureWarning: DataFrame.applymap has been deprecated. Use DataFrame.map instead.
    return pandas_obj.applymap(lambda x: min_val <= x <= max_val)
tests/strategies/test_strategies.py: 30 warnings

/private/tmp/nix-build-python3.13-pandera-0.24.0.drv-0/source/pandera/strategies/pandas_strategies.py:1021: UserWarning: Dataframe check doesn't have a defined strategy. Falling back to filtering drawn values based on the check definition. This can considerably slow down data-generation.

warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

=========================== short test summary info ============================

FAILED tests/polars/test_polars_dtypes.py::test_polars_nested_dtypes_try_coercion[coercible_dtype3-noncoercible_dtype3-data3] - assert False

where False = equals(shape: (1, 1)\n┌─────────────────┐\n│ 0               │\n│ ---             │\n│ list[str]       │\n╞═════════════════╡\n│ ["a", "b", "c"] │\n└─────────────────┘)
where equals = shape: (0, 1)\n┌───────────┐\n│ 0         │\n│ ---       │\n│ list[str] │\n╞═══════════╡\n└───────────┘.equals

 where shape: (0, 1)\n┌───────────┐\n│ 0         │\n│ ---       │\n│ list[str] │\n╞═══════════╡\n└───────────┘ = select(<Expr ['col("0")'] at 0x3221F7950>)



   where select = shape: (0, 2)\n┌───────────┬──────────────┐\n│ 0         ┆ check_output │\n│ ---       ┆ ---          │\n│ list[str] ┆ bool         │\n╞═══════════╪══════════════╡\n└───────────┴──────────────┘.select



     where shape: (0, 2)\n┌───────────┬──────────────┐\n│ 0         ┆ check_output │\n│ ---       ┆ ---          │\n│ list[str] ┆ bool         │\n╞═══════════╪══════════════╡\n└───────────┴──────────────┘ = ParserError("Could not coerce  LazyFrame with schema Schema({'0': List(String)}) into type List(Int64)").failure_cases


and   shape: (1, 1)\n┌─────────────────┐\n│ 0               │\n│ ---             │\n│ list[str]       │\n╞═════════════════╡\n│ ["a", "b", "c"] │\n└─────────────────┘ = collect()

 where collect = <LazyFrame at 0x3504F5D60>.collect



= 1 failed, 3386 passed, 47 skipped, 17 deselected, 8 xfailed, 7629 warnings in 128.62s (0:02:08) =

sarahec · 2025-07-16T20:16:58Z

Discovered in nixpkgs-review of #424873 and #409698

sarahec · 2025-07-16T20:27:41Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 425879
Commit: 640f8b0b2eb88296446d4722568b8408a48cdaa1

`x86_64-linux`

❌ 4 packages failed to build:

python312Packages.pandera
python312Packages.pandera.dist
python313Packages.pandera
python313Packages.pandera.dist

✅ 42 packages built:

jasp-desktop
labplot
python312Packages.dm-sonnet
python312Packages.dm-sonnet.dist
python312Packages.layoutparser
python312Packages.layoutparser.dist
python312Packages.meshtastic
python312Packages.meshtastic.dist
python312Packages.mlcroissant
python312Packages.mlcroissant.dist
python312Packages.pandantic
python312Packages.pandantic.dist
python312Packages.pandas-stubs
python312Packages.pandas-stubs.dist
python312Packages.pdfplumber
python312Packages.pdfplumber.dist
python312Packages.pyreadstat
python312Packages.pyreadstat.dist
python312Packages.tensorflow-datasets
python312Packages.tensorflow-datasets.dist
python312Packages.unstructured-inference
python312Packages.unstructured-inference.dist
python313Packages.layoutparser
python313Packages.layoutparser.dist
python313Packages.meshtastic
python313Packages.meshtastic.dist
python313Packages.mlcroissant
python313Packages.mlcroissant.dist
python313Packages.pandantic
python313Packages.pandantic.dist
python313Packages.pandas-stubs
python313Packages.pandas-stubs.dist
python313Packages.pdfplumber
python313Packages.pdfplumber.dist
python313Packages.pyreadstat
python313Packages.pyreadstat.dist
python313Packages.unstructured-inference
python313Packages.unstructured-inference.dist
readstat
tocpdf
tocpdf.dist
unstructured-api

Error logs: `x86_64-linux`

python312Packages.pandera

tests/strategies/test_strategies.py: 24 warnings
  /build/source/tests/strategies/test_strategies.py:900: FutureWarning: DataFrame.applymap has been deprecated. Use DataFrame.map instead.
    return pandas_obj.applymap(lambda x: min_val <= x <= max_val)
tests/strategies/test_strategies.py: 30 warnings

/build/source/pandera/strategies/pandas_strategies.py:1021: UserWarning: Dataframe check doesn't have a defined strategy. Falling back to filtering drawn values based on the check definition. This can considerably slow down data-generation.

warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

=========================== short test summary info ============================

FAILED tests/polars/test_polars_dtypes.py::test_polars_nested_dtypes_try_coercion[coercible_dtype3-noncoercible_dtype3-data3] - assert False

where False = equals(shape: (1, 1)\n┌─────────────────┐\n│ 0               │\n│ ---             │\n│ list[str]       │\n╞═════════════════╡\n│ ["a", "b", "c"] │\n└─────────────────┘)
where equals = shape: (0, 1)\n┌───────────┐\n│ 0         │\n│ ---       │\n│ list[str] │\n╞═══════════╡\n└───────────┘.equals

 where shape: (0, 1)\n┌───────────┐\n│ 0         │\n│ ---       │\n│ list[str] │\n╞═══════════╡\n└───────────┘ = select(<Expr ['col("0")'] at 0x7FFE039330E0>)



   where select = shape: (0, 2)\n┌───────────┬──────────────┐\n│ 0         ┆ check_output │\n│ ---       ┆ ---          │\n│ list[str] ┆ bool         │\n╞═══════════╪══════════════╡\n└───────────┴──────────────┘.select



     where shape: (0, 2)\n┌───────────┬──────────────┐\n│ 0         ┆ check_output │\n│ ---       ┆ ---          │\n│ list[str] ┆ bool         │\n╞═══════════╪══════════════╡\n└───────────┴──────────────┘ = ParserError("Could not coerce  LazyFrame with schema Schema({'0': List(String)}) into type List(Int64)").failure_cases


and   shape: (1, 1)\n┌─────────────────┐\n│ 0               │\n│ ---             │\n│ list[str]       │\n╞═════════════════╡\n│ ["a", "b", "c"] │\n└─────────────────┘ = collect()

 where collect = <LazyFrame at 0x7FFE51837CB0>.collect



= 1 failed, 3434 passed, 47 skipped, 5 deselected, 8 xfailed, 7650 warnings in 286.41s (0:04:46) =

python313Packages.pandera

tests/strategies/test_strategies.py: 24 warnings
  /build/source/tests/strategies/test_strategies.py:900: FutureWarning: DataFrame.applymap has been deprecated. Use DataFrame.map instead.
    return pandas_obj.applymap(lambda x: min_val <= x <= max_val)
tests/strategies/test_strategies.py: 30 warnings

/build/source/pandera/strategies/pandas_strategies.py:1021: UserWarning: Dataframe check doesn't have a defined strategy. Falling back to filtering drawn values based on the check definition. This can considerably slow down data-generation.

warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

=========================== short test summary info ============================

FAILED tests/polars/test_polars_dtypes.py::test_polars_nested_dtypes_try_coercion[coercible_dtype3-noncoercible_dtype3-data3] - assert False

where False = equals(shape: (1, 1)\n┌─────────────────┐\n│ 0               │\n│ ---             │\n│ list[str]       │\n╞═════════════════╡\n│ ["a", "b", "c"] │\n└─────────────────┘)
where equals = shape: (0, 1)\n┌───────────┐\n│ 0         │\n│ ---       │\n│ list[str] │\n╞═══════════╡\n└───────────┘.equals

 where shape: (0, 1)\n┌───────────┐\n│ 0         │\n│ ---       │\n│ list[str] │\n╞═══════════╡\n└───────────┘ = select(<Expr ['col("0")'] at 0x7FFE25619050>)



   where select = shape: (0, 2)\n┌───────────┬──────────────┐\n│ 0         ┆ check_output │\n│ ---       ┆ ---          │\n│ list[str] ┆ bool         │\n╞═══════════╪══════════════╡\n└───────────┴──────────────┘.select



     where shape: (0, 2)\n┌───────────┬──────────────┐\n│ 0         ┆ check_output │\n│ ---       ┆ ---          │\n│ list[str] ┆ bool         │\n╞═══════════╪══════════════╡\n└───────────┴──────────────┘ = ParserError("Could not coerce  LazyFrame with schema Schema({'0': List(String)}) into type List(Int64)").failure_cases


and   shape: (1, 1)\n┌─────────────────┐\n│ 0               │\n│ ---             │\n│ list[str]       │\n╞═════════════════╡\n│ ["a", "b", "c"] │\n└─────────────────┘ = collect()

 where collect = <LazyFrame at 0x7FFE5152A3F0>.collect



= 1 failed, 3429 passed, 47 skipped, 10 deselected, 8 xfailed, 7650 warnings in 279.57s (0:04:39) =

drupol · 2025-07-16T20:33:28Z

pkgs/by-name/re/readstat/package.nix

why was this removed?

libiconv wasn't actually used.

I thought that we didn't need the parallel building. I'll restore it.

I was not asking for restoring it, I don't even know why it is required. I was merely asking the reasons why it was removed.

Fair enough. It did speed up the build nicely, though!

I was not asking for restoring it, I don't even know why it is required. I was merely asking the reasons why it was removed.

re: libiconv, the boilerplate supplied by autoconf apparently required gettext and libiconv, but those features were never actually used. Since I removed teh requirement on gettext (in the patch), libiconv came away with it.

TomaSajt · 2025-07-16T23:14:36Z

Please change the commit message & PR title: there is no python3Packages.readstat package, only readstat or python3Packages.pyreadstat.
In this case readstat would be correct.

gettext 0.25 has been breaking older autoconf setups. Patch it out.

nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Jul 16, 2025

nix-owners bot requested a review from swflint July 16, 2025 19:17

sarahec force-pushed the fix-readstat-build branch 2 times, most recently from 057f1dc to 640f8b0 Compare July 16, 2025 19:33

sarahec mentioned this pull request Jul 16, 2025

python3Packages.pandera: 0.24.0 -> 0.25.0 #425899

Merged

13 tasks

sarahec requested a review from drupol July 16, 2025 20:28

drupol reviewed Jul 16, 2025

View reviewed changes

sarahec force-pushed the fix-readstat-build branch from 640f8b0 to 9462cc6 Compare July 16, 2025 21:02

drupol approved these changes Jul 16, 2025

View reviewed changes

nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 16, 2025

wegank force-pushed the fix-readstat-build branch from 9462cc6 to 7800905 Compare July 17, 2025 02:05

wegank changed the title ~~python3Packages.readstat: fix build failure~~ readstat: fix build failure Jul 17, 2025

readstat: fix build failure

dd95865

gettext 0.25 has been breaking older autoconf setups. Patch it out.

wegank force-pushed the fix-readstat-build branch from 7800905 to dd95865 Compare July 17, 2025 02:06

wegank merged commit a198fae into NixOS:master Jul 17, 2025
23 of 27 checks passed

sarahec deleted the fix-readstat-build branch July 17, 2025 04:12

AndrewKvalheim mentioned this pull request Jul 19, 2025

[staging-next] sage: unpin python, adapt to scipy 1.16 update #423832

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

readstat: fix build failure#425879

readstat: fix build failure#425879
wegank merged 1 commit intoNixOS:masterfrom
sarahec:fix-readstat-build

sarahec commented Jul 16, 2025 •

edited by TomaSajt

Loading

Uh oh!

sarahec commented Jul 16, 2025

Uh oh!

sarahec commented Jul 16, 2025 •

edited

Loading

Uh oh!

sarahec commented Jul 16, 2025

Uh oh!

drupol Jul 16, 2025

Uh oh!

sarahec Jul 16, 2025

Uh oh!

sarahec Jul 16, 2025

Uh oh!

drupol Jul 16, 2025

Uh oh!

sarahec Jul 16, 2025

Uh oh!

sarahec Jul 16, 2025

Uh oh!

TomaSajt commented Jul 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

sarahec commented Jul 16, 2025 • edited by TomaSajt Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Things done

Uh oh!

sarahec commented Jul 16, 2025

nixpkgs-review result

aarch64-darwin

Uh oh!

sarahec commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sarahec commented Jul 16, 2025

nixpkgs-review result

x86_64-linux

Uh oh!

drupol Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

sarahec Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

sarahec Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

drupol Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

sarahec Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

sarahec Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

TomaSajt commented Jul 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sarahec commented Jul 16, 2025 •

edited by TomaSajt

Loading

`nixpkgs-review` result

`aarch64-darwin`

sarahec commented Jul 16, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`