python3Packages.torch: explicitly include libopenmp on Darwin x86_64#430808
Merged
NickCao merged 1 commit intoNixOS:masterfrom Aug 4, 2025
Merged
python3Packages.torch: explicitly include libopenmp on Darwin x86_64#430808NickCao merged 1 commit intoNixOS:masterfrom
NickCao merged 1 commit intoNixOS:masterfrom
Conversation
Contributor
Author
|
Contributor
Author
|
Contributor
Author
|
Normally an empty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #424873 fixed multiple builds hanging by disabling a "duplicate"* copy of the OpenMP dylib on Darwin. While this fixed, aarch64, this broke compilation on x86_64 (see #430472).
This PR omits the "duplicate" copy only on aarch64 and restores it on x86_64.
* "Duplicate": two copies of the dylib visible while running. Normally this is a non-issue on Darwin, but FAISS crashes on ARM with multiple copies of openMP visible. (See pytorch/pytorch#149201 (comment))
Fixes #430472
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.