python3Packages.sentence-transformers: disable test that segfaults on Darwin#422742
Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom Jul 6, 2025
Merged
Conversation
Contributor
Author
|
Discovered in |
nixpkgs-ci
bot
added
the
6.topic: python
nixpkgs-ci
bot
added
10.rebuild-darwin: 11-100
sarahec
force-pushed
the
sentence-transformers-segfault-goodbye
branch
from
4e363fc to
75b51f1
Compare
GaetanLepage
reviewed
Jul 5, 2025
Contributor
There was a problem hiding this comment.
Suggested change
| # Segment fault | |
| # Segmentation fault |
(or Segfault).
Nit: feel free to ignore.
Contributor
Author
There was a problem hiding this comment.
Silly autodefect got me. Fixed.
sarahec
force-pushed
the
sentence-transformers-segfault-goodbye
branch
from
75b51f1 to
781b235
Compare
GaetanLepage
reviewed
Jul 5, 2025
Contributor
There was a problem hiding this comment.
Sorry, last nit if you don't mind. Can you move stdenv just below lib please?
Otherwise, LGTM!
sarahec
force-pushed
the
sentence-transformers-segfault-goodbye
branch
from
781b235 to
2ae3d1a
Compare
Contributor
|
Contributor
Author
|
Taking this to draft while its prerequisites get merged. |
13 tasks
Contributor
Author
|
Contributor
Author
|
@GaetanLepage this one's good to go. |
GaetanLepage
approved these changes
Jul 6, 2025
Contributor
Author
|
Reverted in #424873 due to underlying cause in torch. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabled
tests/test_sparse_tensor.pyon Darwin due to a segfault.Requires #422747
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.