electron_32-bin: mark as insecure because it's EOL, electron-source.electron_32: remove as it's EOL#383660
Merged
emilylange merged 2 commits intoNixOS:masterfrom Mar 7, 2025
Merged
Conversation
f5272b5 to
4131d5f
Compare
13 tasks
13 tasks
13 tasks
4131d5f to
35d19b6
Compare
13 tasks
20d0359 to
b4561d0
Compare
b4561d0 to
c248857
Compare
13 tasks
teutat3s
added a commit
to teutat3s/nixpkgs
that referenced
this pull request
Mar 8, 2025
This patch is no longer needed, because we don't build electron 32 from source anymore since NixOS#383660.
13 tasks
yuyuyureka
pushed a commit
that referenced
this pull request
Mar 12, 2025
This patch is no longer needed, because we don't build electron 32 from source anymore since #383660.
sandptel
pushed a commit
to sandptel/nixpkgs
that referenced
this pull request
Mar 13, 2025
This patch is no longer needed, because we don't build electron 32 from source anymore since NixOS#383660.
22 tasks
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously:
electron_32will be EOL in two weeks (2025-03-04).https://www.electronjs.org/docs/latest/tutorial/electron-timelines (permalink)
This PR removes the source build on Linux for electron 32 and marks the binary variants for Darwin and Linux as insecure.
electron_32will still be available for an undetermined while. Linux will simply use the binary package instead of the source build, just like Darwin.After this PR has been merged, users will be able opt-into the EOL version of electron as outlined by this eval error message:
The following packages are affected by this. Note that those package will continue to work, but users will be presented with the eval error above and have to opt-in.
If you are pinged as one of the maintainers of such package, you can do one of the following:
heroic(@aidalgol) heroic-unwrapped: electron 32 -> electron 33 #383732legcord(@wrmilling @water-sucks) legcord: 1.0.8 -> 1.1.0, electron_32 -> electron_34 #383696lx-music-desktop(@oosquare)morgen(@justanotherariel)teams-for-linux(@muscaln @qjoly @chvp @khaneliman) teams-for-linux: electron_32 -> electron_33 #383663zulip(@andersk)Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)