Skip to content

Comments

[Backport release-24.11] electron_32-bin: mark as insecure because it's EOL, electron-source.electron_32: remove as it's EOL#387869

Merged
emilylange merged 2 commits intoNixOS:release-24.11from
emilylange:backport-383660-to-release-24.11
Mar 7, 2025
Merged

[Backport release-24.11] electron_32-bin: mark as insecure because it's EOL, electron-source.electron_32: remove as it's EOL#387869
emilylange merged 2 commits intoNixOS:release-24.11from
emilylange:backport-383660-to-release-24.11

Conversation

@emilylange
Copy link
Member

Manual backport of #383660.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@emilylange emilylange added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Mar 7, 2025
@nix-owners nix-owners bot requested a review from networkException March 7, 2025 10:45
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 7, 2025
@nix-owners nix-owners bot requested review from teutat3s and yayayayaka March 7, 2025 10:51
@emilylange emilylange merged commit b9e432f into NixOS:release-24.11 Mar 7, 2025
25 of 28 checks passed
@emilylange emilylange deleted the backport-383660-to-release-24.11 branch March 7, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants