legcord: 1.0.8 -> 1.1.0, electron_32 -> electron_34

[wrmilling]

https://github.com/Legcord/Legcord/releases/tag/v1.1.0

legcord: electron_32 -> electron_34

Updating legcord to the latest version and syncing electron to the upstream supported version as triggered by #383660.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[water-sucks]

Did some rudimentary testing on x86_64-linux, seems to be working to me.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 383696

---

x86_64-linux

✅ 1 package built:

• legcord

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2259

[nixpkgs-ci]

Successfully created backport PR for release-24.11:

• [Backport release-24.11] legcord: 1.0.8 -> 1.1.0, electron_32 -> electron_34 #384522

[nyabinary]

Question wouldn't of this needed something similar done to the vesktop derivative since legcord is using venmic now? Wouldn't this require the use of autoPatchelfHook?
Legcord/Legcord#819

[wrmilling]

Question wouldn't of this needed something similar done to the vesktop derivative since legcord is using venmic now? Wouldn't this require the use of autoPatchelfHook?

Possibly, I do not daily drive my ARM64 laptop anymore and my limited manual testing for this release did not show any glaring issues with screen sharing / audio. Have you seen any problems with audio while screen sharing on 1.1.0?

[nyabinary]

Question wouldn't of this needed something similar done to the vesktop derivative since legcord is using venmic now? Wouldn't this require the use of autoPatchelfHook?

Possibly, I do not daily drive my ARM64 laptop anymore and my limited manual testing for this release did not show any glaring issues with screen sharing / audio. Have you seen any problems with audio while screen sharing on 1.1.0?

While screen sharing with audio with my friend, my friend can hear the echo of themselves, even when an individual window is selected, it streams the whole audio not just the selected window.