Skip to content

Comments

heroic-unwrapped: electron 32 -> electron 33#383732

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
khaneliman:heroic
Feb 21, 2025
Merged

heroic-unwrapped: electron 32 -> electron 33#383732
GaetanLepage merged 1 commit intoNixOS:masterfrom
khaneliman:heroic

Conversation

@khaneliman
Copy link
Contributor

Seems to build and run fine even though upstream hasn't updated.

Related #383660

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Seems to build and run fine even though upstream hasn't updated.
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 20, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 383732


x86_64-linux

✅ 2 packages built:
  • heroic
  • heroic-unwrapped

@GaetanLepage GaetanLepage merged commit aa5fdef into NixOS:master Feb 21, 2025
25 of 27 checks passed
@khaneliman khaneliman deleted the heroic branch February 21, 2025 15:48
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 22, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants