electron-{source,bin}: various cleanups#388242
Merged
yuyuyureka merged 2 commits intoNixOS:masterfrom Mar 12, 2025
Merged
Conversation
…s systems Cleanup, because electron 34.3.0 and 33.4.1 already contain the fix upstream and have reached nixpkgs master. https://github.com/electron/electron/releases/tag/v34.3.0 electron/electron#45571 https://github.com/electron/electron/releases/tag/v33.4.1 electron/electron#45602
This patch is no longer needed, because we don't build electron 32 from source anymore since NixOS#383660.
github-actions
bot
added
10.rebuild-darwin: 0
TomaSajt
approved these changes
Mar 8, 2025
Contributor
TomaSajt
left a comment
TomaSajt
left a comment
There was a problem hiding this comment.
Seems pretty straightforward, LGTM
Member
Author
|
teutat3s
added
12.approved-by: package-maintainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes no longer needed fix that was implemented in #382497, no longer needed because upstream electron 33 + 34 have the fix.
https://github.com/electron/electron/releases/tag/v34.3.0
electron/electron#45571
https://github.com/electron/electron/releases/tag/v33.4.1
electron/electron#45602
Removes a patch which is no longer needed, because we don't build electron 32 from
source anymore since #383660.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.