electron_32-bin, electron-chromedriver_32: 32.3.2 -> 32.3.3

[teutat3s]

Last security update for electron_32, it's now EOL.
https://github.com/electron/electron/releases/tag/v32.3.3

I'm only updating the bin variant of electron_32, because the source variant will soon be dropped, see #383660.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[yuyuyureka]

getting a build error on electron_35 on aarch64-linux:

                                                                                                                                                                       >
Did you mean "use_qt5"?

The variable "use_qt" was set as a build argument
but never appeared in a declare_args() block in any buildfile.

To view all possible args, run "gn args --list <out_dir>"

The build continued as if that argument was unspecified.

Done. Made 24716 targets from 3963 files in 6205ms
WARNING
Found gn WARNING, exiting nix build

Thank you so much for taking care of the updates

[yuyuyureka]

This should do:

diff --git a/pkgs/applications/networking/browsers/chromium/common.nix b/pkgs/applications/networking/browsers/chromium/common.nix
index a664ae6b9f69..530ba875ec63 100644
--- a/pkgs/applications/networking/browsers/chromium/common.nix
+++ b/pkgs/applications/networking/browsers/chromium/common.nix
@@ -726,7 +726,7 @@ let
         # Disable PGO because the profile data requires a newer compiler version (LLVM 14 isn't sufficient):
         chrome_pgo_phase = 0;
         clang_base_path = "${llvmCcAndBintools}";
-        ${chromiumVersionAtLeast "134" then "use_qt5" else "use_qt"} = false;
+        ${if (chromiumVersionAtLeast "134") then "use_qt5" else "use_qt"} = false;
         # To fix the build as we don't provide libffi_pic.a
         # (ld.lld: error: unable to find library -l:libffi_pic.a):
         use_system_libffi = true;

[yuyuyureka]

I suggest splitting this PR into one for the updates up to 34.x, and another one for packaging 35 and making it the default

[emilylange]

You likely want to wait with electron_35 source builds until I have opened and merged the chromium M133 -> M134 PR.

And I hope you are aware of the implications of this.
I can only assume if you feel like this is the right time to reintroduce source builds again, that you

• have onboarded a bunch of new folks to electron.meta.maintainers
• can open, review and merge PRs for security critical releases within 72h (give or take)
• unbreak electron in a time manner when staging inevitably breaks it again
• will remove releases, both source and binary, that went EOL
• are aware that this puts additional strain on the chromium maintainers

I will not block this PR, but I am genuinely offended by this.
In the same way that you closed #295770 as resolved without solving the underlying issue.

But hey, maybe you could ask @yuyuyureka if she wants to add herself to electron.meta.maintainers again.

[teutat3s]

@emilylange I intended no offense here. Please know that I saw all the work you put into electron these past weeks / months and I'm thankful for that.

If you feel like going for non-source, bin-only for now is preferable, I have no objections. My intention here was to give some of my time as well, not to offend anyone.

EDIT: "Solving the underlying issue" - I'd like to know your thoughts what would be required to achieve that. Feel free to re-open that linked issue with a comment.

[yuyuyureka]

But hey, maybe you could ask @yuyuyureka if she wants to add herself to electron.meta.maintainers again.

Nope.

I want electron-source to continue to exist because I have put years of work into getting it into the state it is now.
But I have been burned over the years from the general feeling that in nixpkgs, people do not work together, but against each other. I'm done doing regular maintenance tasks in electron. I'm done with discussing and having to fight to find any doable solution and then still someone always being angry.

But I can be pinged when help is needed to achieve some specific one-off task. teutat3s has my Matrix contact too for when there are questions.

[emilylange]

There is a lot of hidden context, depth and frustration to this, which eventually caused me to snap and comment the way I did. @teutat3s messaged me on Matrix shortly after and we chatted a bit. I believe things are good between us again.

I will, however, take a break from trying to help maintain electron.
Though it's fairly likely that I may touch electron by proxy due to some refactoring and cleanup in chromium.
I just won't continue doing the things I did the past few months.

And finally, I intend to comment under #295770 as @teutat3s suggested. Just not sure when I find the spoons for that. Maybe in a week or two.

Guess we will see.

[nixpkgs-ci]

Successfully created backport PR for release-24.11:

• [Backport release-24.11] electron_32-bin, electron-chromedriver_32: 32.3.2 -> 32.3.3 #387885