python3Packages.cffi: fix missing fn on old macos #280538
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reports: * Nixpkgs: NixOS#210749 * Upstream: kazeburo/POSIX-strftime-Compiler#8
* Tracking issue: NixOS#277198
citations: fix build on darwin
https://gitlab.gnome.org/GNOME/folks/-/compare/0.15.6...0.15.7 Also re-enable doCheck on Linux, and workaround Clang 16 build issue.
GNOME updates 2024-01-09
morewaita-icon-theme: init at 42.3
immich-cli: 0.41.0 -> 2.0.6
Other kernels have their kernel at top level, but zen's are missing.
python311Packages.aiosomecomfort: 0.0.24 -> 0.0.25
java-service-wrapper: enable aarch64-linux platform
…splus-mark-broken-musl pkgsMusl.dbus_cplusplus: mark broken for Musl
…Compiler-mark-broken-musl pkgsMusl.perl536Packages.POSIXstrftimeCompiler: mark broken for Musl
kubevela: init 1.9.8
arti: 1.1.11 -> 1.1.12 Closes NixOS#280437
linux_zen, linux_lqx: add missing top-level attributes
lualatex assumes a writeable font cache relative to `$HOME`, for nix this has two implications. First, the cache might diverge from the nix store if users use LuaLaTeX. Second, `$HOME` needs to be set to a writable path in derivations.
remnote: 1.13.0 -> 1.13.34
julia_110: init at 1.10.0
crosvm: 119.0 -> 120.0
smbmap: 1.9.2 -> 1.10.2
skytemple: 1.6.0 -> 1.6.3
sidplayfp: 2.6.0 -> 2.6.2
If I understand correctly (I may not), cffi is assuming the system libffi here, which doesn't apply in our case. The underlying defines (which affect macOS before 10.15) have been in cffi for 4+ years now, so I'm not quite sure how we haven't picked up on it already.
github-actions
bot
added
the
6.topic: python
github-actions
bot
added
6.topic: nixos
Member
Author
|
ick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of testing out the fix that ultimately landed in #278945, I ran into the following missing-function error in cffi's test suite:
The missing function is in turn caused by these defines: https://github.com/python-cffi/cffi/blame/feaff378873d8a3f52bbb63f7d5e24f9ab18f1e9/src/c/_cffi_backend.c#L106-L113
If I understand correctly (I may not), cffi is assuming the system libffi here, which doesn't apply in our case.
(The underlying defines (which affect macOS before 10.15) have been in cffi for 4+ years now, so I'm not quite sure how we haven't picked up on it already.)
Description of changes
I edited the patch for this behavior (pkgs/development/python-modules/cffi/darwin-use-libffi-closures.diff) to remove the version check.
I'm not certain this is correct, so I'll open this as a draft for now. I went ahead and did this for all 3 checks, even though I suspect we didn't need all of them to pass the test failure above.
Things done
I was able to successfully build and use
nixwith this patch present.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.