linux_zen, linux_lqx: add missing top-level attributes #276175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atemu
reviewed
Dec 23, 2023
pkgs/top-level/all-packages.nix
Outdated
Member
There was a problem hiding this comment.
I'd prefer to keep it in line with the other entries.
Suggested change
| linux_zen = linuxPackages_zen.kernel; | |
| linux_zen = linuxKernel.kernels.linux_zen |
Contributor
Author
There was a problem hiding this comment.
It's pretty inconsistent, the other kernels have a mix of both.
ofborg
bot
added
8.has: package (new)
Atemu
requested changes
Dec 23, 2023
Member
Atemu
left a comment
Atemu
left a comment
There was a problem hiding this comment.
Please follow the commit message guidelines in CONTRIBUTING.md.
Contributor
Author
|
@Atemu hi, is the updated commit message ok now? |
Member
|
Hi, please read https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions Your message should look something like this: |
Other kernels have their kernel at top level, but zen's are missing.
Contributor
Author
|
@Atemu fixed, thanks. |
Atemu
changed the title
Atemu
approved these changes
Jan 12, 2024
1 task
Contributor
|
Successfully created backport PR for |
Contributor
|
Git push to origin failed for release-23.11 with exitcode 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other kernels have their kernel at top level, but zen's are missing.
Description of changes
Add linux_zen and linux_lqx kernels to top level.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.