Skip to content

GNOME updates 2024-01-09 #279843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bobby285271 merged 7 commits into from
Jan 12, 2024
Merged

GNOME updates 2024-01-09 #279843

bobby285271 merged 7 commits into from
Jan 12, 2024

Conversation

@bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Jan 9, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jan 9, 2024
@bobby285271
Copy link
Member Author

bobby285271 commented Jan 9, 2024 •
edited
Loading

I moved the libdex bump to #279847 because the newly added test is probably flaky (and I can't reproduce locally yet).

@ofborg test gnome-xorg

@bobby285271 bobby285271 marked this pull request as ready for review January 9, 2024 14:44
@bobby285271 bobby285271 requested a review from jtojnar as a code owner January 9, 2024 14:44
@ofborg ofborg bot requested review from amaxine, dasj19 and hedning January 9, 2024 14:46
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 9, 2024
@bobby285271
Copy link
Member Author

bobby285271 commented Jan 9, 2024 •
edited
Loading

@ofborg build folks Builds on github-actions macos-latest, going to sleep. I will give +1 if dropping darwin support is preferred here.

@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jan 10, 2024
amaxine
amaxine approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@amaxine amaxine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff and upstream changes look good to me.

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 10, 2024
@bobby285271 bobby285271 merged commit 30ed0d9 into NixOS:master Jan 12, 2024
@bobby285271 bobby285271 deleted the upd/gnome branch January 12, 2024 12:45
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024

Successfully created backport PR for release-23.11:

@amaxine
Copy link
Contributor

amaxine commented Jan 13, 2024

We might want to disable doCheck for folks again, I'm getting timeouts under busier circumstances than when just building this PR. That, or increasing the timeout multiplier more, I guess?

@bobby285271
Copy link
Member Author

bobby285271 commented Jan 13, 2024 •
edited
Loading

We might want to disable doCheck for folks again

Fine for me (though we are already on --timeout-multiplier 4 I might consider this abnormal).

Is that a specific subtest that stuck? It would be really weird if it randomly stuck at 31/32 as said in 3d6f2ec

@amaxine
Copy link
Contributor

amaxine commented Jan 13, 2024

No, 6 tests timed out for me on the first run. I'm having trouble reproing again but I can hammer things with a webkit rebuild I guess to try and recreate the conditions again 😅

@amaxine amaxine mentioned this pull request Jan 14, 2024
Merged
13 tasks
@amaxine
Copy link
Contributor

amaxine commented Jan 14, 2024

Disabling checks again for folks in #280909.

github-actions bot pushed a commit that referenced this pull request Jan 14, 2024
@amaxine @github-actions
folks: disable checks
42e222e 
checks were re-enabled in #279843 / 10dad20
but inconsistent timeouts still occur

(cherry picked from commit f5dfc97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

@dasj19 dasj19 Awaiting requested review from dasj19

1 more reviewer

@amaxine amaxine amaxine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobby285271 @amaxine @delroth