Skip to content

Conversation

@superherointj
Copy link
Contributor

java-service-wrapper: enable aarch64-linux platform

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 12, 2024
@ofborg ofborg bot requested a review from suhr January 12, 2024 13:09
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 12, 2024
@suhr
Copy link
Contributor

suhr commented Jan 12, 2024

Should it be just platforms.linux?

@superherointj
Copy link
Contributor Author

superherointj commented Jan 12, 2024

Should it be just platforms.linux?

I have only tested in aarch64-linux, there is riscv for example.

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 12, 2024
Copy link
Member

@ulrikstrid ulrikstrid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward, should not impact current users

@ulrikstrid ulrikstrid merged commit 24384a8 into NixOS:master Jan 12, 2024
@superherointj superherointj deleted the java-service-wrapper branch January 12, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants