Skip to content

Conversation

@benneti
Copy link
Contributor

@benneti benneti commented Jan 10, 2024

lualatex assumes a writeable font cache relative to $HOME, for nix this has two implications. First, the cache might diverge from the nix store if users use LuaLaTeX. Second, $HOME needs to be set to a writable path in derivations.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 6.topic: TeX Issues regarding texlive and TeX in general labels Jan 10, 2024
@benneti
Copy link
Contributor Author

benneti commented Jan 10, 2024

I don't know how to tell this to github, but from my side this would close #278718

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 10, 2024
@benneti benneti requested review from veprbl and xworld21 January 11, 2024 15:28
@veprbl veprbl linked an issue Jan 11, 2024 that may be closed by this pull request
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 11, 2024
@benneti benneti force-pushed the lualatex-font-docs branch from f011052 to 1591ca4 Compare January 12, 2024 15:32
lualatex assumes a writeable font cache relative to `$HOME`, for nix this has two implications.
First, the cache might diverge from the nix store if users use LuaLaTeX.
Second, `$HOME` needs to be set to a writable path in derivations.
@benneti benneti force-pushed the lualatex-font-docs branch from 6219276 to d22588d Compare January 12, 2024 15:38
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 12, 2024
@veprbl
Copy link
Member

veprbl commented Jan 12, 2024

Thanks!

@veprbl veprbl merged commit b28200a into NixOS:master Jan 12, 2024
@benneti benneti deleted the lualatex-font-docs branch January 12, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: TeX Issues regarding texlive and TeX in general 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

texlive broken fira font in lualatex (with fontsetup)

3 participants