kubevela: init 1.9.8 #274721
Merged
kubevela: init 1.9.8 #274721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
Contributor
Author
|
@bryanasdev000 Review? |
bryanasdev000
suggested changes
Dec 27, 2023
Contributor
bryanasdev000
left a comment
bryanasdev000
left a comment
There was a problem hiding this comment.
Overall, LGTM, just a nitpick about ldflags and empty maintainers.
bryanasdev000
approved these changes
Dec 28, 2023
bryanasdev000
added
12.approvals: 1
Contributor
|
@superherointj could you please take a look on the tests? https://github.com/NixOS/nixpkgs/pull/274721/checks?check_run_id=19706550471 |
delroth
added
the
12.approvals: 1
superherointj
force-pushed
the
kubevela-1.9.7
branch
2 times, most recently
from
7b93457 to
f3e68fb
Compare
Contributor
Author
Fixed. |
delroth
removed
the
12.approvals: 1
bryanasdev000
suggested changes
Jan 10, 2024
Contributor
bryanasdev000
left a comment
bryanasdev000
left a comment
There was a problem hiding this comment.
Diff LGTM, but there is a new release out, would be cool to init it on latest.
superherointj
force-pushed
the
kubevela-1.9.7
branch
from
f3e68fb to
98d5664
Compare
bryanasdev000
approved these changes
Jan 11, 2024
Contributor
bryanasdev000
left a comment
bryanasdev000
left a comment
There was a problem hiding this comment.
Diff and ofborg LGTM.
bryanasdev000
added
the
12.approvals: 1
ulrikstrid
approved these changes
Jan 12, 2024
Member
ulrikstrid
left a comment
ulrikstrid
left a comment
There was a problem hiding this comment.
Builds and some basic commands runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubevela: init 1.9.8
Release: https://github.com/kubevela/kubevela/releases/tag/v1.9.8
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.