zulip: build package from source#279545
Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom Dec 6, 2024
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
andersk
suggested changes
Jan 8, 2024
Contributor
andersk
left a comment
andersk
left a comment
There was a problem hiding this comment.
Thanks for working on this. It doesn’t work as written though.
pkgs/applications/networking/instant-messengers/zulip/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/zulip/default.nix
Outdated
Show resolved
Hide resolved
Contributor
|
I’ve updated the app for Electron 28. Let’s merge that first so we can use the version of Electron the app expects: |
nbdd0121
force-pushed
the
zulip
branch
2 times, most recently
from
cea415f to
e29eaff
Compare
Member
Author
|
@andersk could you take another look? |
wegank
added
the
2.status: merge conflict
Contributor
|
lgtm, not familiar with electron though |
ofborg
bot
removed
the
2.status: merge conflict
andersk
reviewed
Nov 6, 2024
pkgs/applications/networking/instant-messengers/zulip/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/zulip/default.nix
Outdated
Show resolved
Hide resolved
nbdd0121
force-pushed
the
zulip
branch
2 times, most recently
from
66e062f to
c9c4f25
Compare
wegank
added
the
2.status: merge conflict
andersk
approved these changes
Nov 11, 2024
andersk
added
12.approved-by: package-maintainer
wegank
added
the
12.approvals: 1
andersk
approved these changes
Nov 11, 2024
Member
Author
|
Rebased to resolve conflict with #358620 |
andersk
approved these changes
Dec 1, 2024
andersk
approved these changes
Dec 2, 2024
JohnRTitor
reviewed
Dec 3, 2024
github-actions
bot
removed
the
10.rebuild-linux: 1
JohnRTitor
reviewed
Dec 6, 2024
Currently this uses AppImage which comes with its own electron and then we run it under FHS. This is not ideal since: * it suffers from "too many electrons" issue * we are relying upstream to bump electron version for bugfixes Signed-off-by: John Titor <50095635+JohnRTitor@users.noreply.github.com>
JohnRTitor
approved these changes
Dec 6, 2024
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-279545-to-release-24.11 origin/release-24.11
cd .worktree/backport-279545-to-release-24.11
git switch --create backport-279545-to-release-24.11
git cherry-pick -x 2160e7db923d9ded9787975891de5dfd07192961 |
1 similar comment
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-279545-to-release-24.11 origin/release-24.11
cd .worktree/backport-279545-to-release-24.11
git switch --create backport-279545-to-release-24.11
git cherry-pick -x 2160e7db923d9ded9787975891de5dfd07192961 |
13 tasks
nbdd0121
added a commit
to nbdd0121/nixpkgs
that referenced
this pull request
Dec 10, 2024
Currently this uses AppImage which comes with its own electron and then we run it under FHS. This is not ideal since: * it suffers from "too many electrons" issue * we are relying upstream to bump electron version for bugfixes Signed-off-by: John Titor <50095635+JohnRTitor@users.noreply.github.com> (cherry picked from commit 2160e7d)
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Currently this uses AppImage which comes with its own electron. This is not ideal since:
It's not very difficult to build it from source anyway.
After this PR the package size (excluding dependencies) is reduced from 160M to 16M.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.