treewide: add `--enable-wayland-ime` flag to all Electron packages that uses `NIXOS_OZONE_WL` by 34j · Pull Request #358620 · NixOS/nixpkgs

34j · 2024-11-24T04:34:40Z

Adds --enable-wayland-ime flag to all Electron packages that uses NIXOS_OZONE_WL

According to Fcitx 5 wiki, it seems it is always recommended to add --enable-wayland-ime or --gtk-version=4 (which is only supported in chromium/chrome) flag when launching Electron apps to use text-input-v1. (https://fcitx-im.org/wiki/Using_Fcitx_5_on_Wayland#Chromium_.2F_Electron) See #358368 for further information.

Things done

import re

from collections import defaultdict
from pathlib import Path

# for each nix file in the pkgs directory
for path in Path('pkgs').rglob('*.nix'):
    txt = path.read_text()
    
    # find NIXOS_OZONE_WL
    # start_text = '''"\''${NIXOS_OZONE_WL:+\''${WAYLAND_DISPLAY:+'''
    match = re.search(r'\${WAYLAND_DISPLAY\:\+(.+?)}}', txt)
    if match:
        if "--enable-wayland-ime" not in match.group(1):
            print(path)
            txt = txt.replace(match.group(1), match.group(1) + " --enable-wayland-ime")
            path.write_text(txt)

Add a 👍 reaction to pull requests you find important.

…IXOS_OZONE_WL`

34j · 2024-11-24T13:06:50Z

$ nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
this path will be fetched (0.06 MiB download, 0.32 MiB unpacked):
  /nix/store/88qfwfcy14r5gha7ysb8534dydp3xilb-nixpkgs-review-2.10.4
copying path '/nix/store/88qfwfcy14r5gha7ysb8534dydp3xilb-nixpkgs-review-2.10.4' from 'https://cache.nixos.org'...
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 23, done.
remote: Counting objects: 100% (20/20), done.
remote: Compressing objects: 100% (7/7), done.
remote: Total 11 (delta 8), reused 4 (delta 3), pack-reused 0 (from 0)
Unpacking objects: 100% (11/11), 1.63 KiB | 557.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
 * [new branch]                master     -> refs/nixpkgs-review/0
$ git worktree add /home/*/.cache/nixpkgs-review/rev-8ae2932d567cbe792ddfebd537be6fd66f594179/nixpkgs 3f038acf2daed76afe3a96edd8a2e604db8924e0
Preparing worktree (detached HEAD 3f038acf2dae)
Updating files: 100% (44499/44499), done.
HEAD is now at 3f038acf2dae ufetch: 0.3 -> 0.4 (#358611)
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/*/.cache/nixpkgs-review/rev-8ae2932d567cbe792ddfebd537be6fd66f594179/nixpkgs nixpkgs-overlays=/tmp/tmpdr8p23xi -qaP --xml --out-path --show-trace --no-allow-import-from-derivation
$ git merge --no-commit --no-ff 8ae2932d567cbe792ddfebd537be6fd66f594179
Automatic merge went well; stopped before committing as requested
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/*/.cache/nixpkgs-review/rev-8ae2932d567cbe792ddfebd537be6fd66f594179/nixpkgs nixpkgs-overlays=/tmp/tmpdr8p23xi -qaP --xml --out-path --show-trace --no-allow-import-from-derivation --meta
132 packages updated:
1password 1password affine altair anytype aws-azure-login bazecor beekeeper-studio beeper betaflight-configurator bitwarden-desktop bitwarden-directory-connector blockbench brave bruno caprine chatzone-desktop chromium cider cider code codium cursor deltachat-desktop discord discord-canary discord-development discord-ptb drawio drawio-headless element-desktop element-desktop emuflight-configurator fast-cli feishin ferdium figma-linux flaresolverr framesh franz freetube geogebra github-desktop gitify gitkraken goofcord google-chrome gotenberg grafana-kiosk gridtracker httptoolkit icestudio inav-configurator itch jitsi-meet-electron joplin-desktop kando keybase-gui koodo-reader kuro legcord lens-desktop lunarclient mattermost-desktop mermaid-cli mermaid-filter microsoft-edge morgen mqtt-explorer muffon mullvad-vpn multiviewer-for-f1 netflix-via-google-chrome nwjs nwjs obsidian OnlyKey pandoc-drawio-filter percollate pinegrow pinegrow pinnwand playwright-test plexamp podman-desktop popcorntime postman proton-pass protonmail-desktop puppeteer-cli python3.11-django-filingcabinet python3.11-great-tables python3.11-mkdocs-drawio-exporter python3.11-pytest-playwright python3.11-shiny python3.12-django-filingcabinet python3.12-great-tables python3.12-mkdocs-drawio-exporter python3.12-pytest-playwright python3.12-shiny r2modman redact redisinsight revolt-desktop ride session-desktop Sharedown signal-desktop single-file-cli sitespeed-io slack spotify spotifywm teams-for-linux tidal-hifi uhk-agent uhk-udev-rules ungoogled-chromium upscayl vhs vivaldi vscode vscode-extension-yzane-markdown-pdf vscode-with-extensions vscodium wavebox wayback wootility youtube-music ytmdesktop zettlr zulip

$ nix build --file /nix/store/88qfwfcy14r5gha7ysb8534dydp3xilb-nixpkgs-review-2.10.4/lib/python3.11/site-packages/nixpkgs_review/nix/review-shell.nix --nix-path nixpkgs=/home/*/.cache/nixpkgs-review/rev-8ae2932d567cbe792ddfebd537be6fd66f594179/nixpkgs nixpkgs-overlays=/tmp/tmpdr8p23xi --extra-experimental-features nix-command no-url-literals --no-link --keep-going --no-allow-import-from-derivation --option build-use-sandbox relaxed --argstr system x86_64-linux --argstr nixpkgs-path /home/*/.cache/nixpkgs-review/rev-8ae2932d567cbe792ddfebd537be6fd66f594179/nixpkgs --argstr nixpkgs-config-path /tmp/tmpap0htciy.nix --argstr attrs-path /home/*/.cache/nixpkgs-review/rev-8ae2932d567cbe792ddfebd537be6fd66f594179/attrs.nix
error: builder for '/nix/store/rdk1915j2caqdin2gkjkicc9z06j6h9j-Cider-linux-appimage-x64.AppImage.drv' failed with exit code 1;
       last 10 log lines:
       > ***
       > Unfortunately, we cannot download file Cider-linux-appimage-x64.AppImage automatically.
       > Please go to https://cidercollective.itch.io/cider to download it yourself, and add it to the Nix store
       > using either
       >   nix-store --add-fixed sha256 Cider-linux-appimage-x64.AppImage
       > or
       >   nix-prefetch-url --type sha256 file:///path/to/Cider-linux-appimage-x64.AppImage
       >
       > ***
       >
       For full logs, run 'nix log /nix/store/rdk1915j2caqdin2gkjkicc9z06j6h9j-Cider-linux-appimage-x64.AppImage.drv'.
error: 1 dependencies of derivation '/nix/store/9xl44clvxpck74rbs79824z40zwl15j0-cider-2-2.5.0-extracted.drv' failed to build
error: 1 dependencies of derivation '/nix/store/27r13psy895c4gf072jfsiy152z5726s-cider-2.5.0-extracted.drv' failed to build
error: 1 dependencies of derivation '/nix/store/whdx7rvp6ch6n81i923vzf4fzvw5rndz-cider-2-2.5.0-init.drv' failed to build
[7/158/614 built (1 failed), 16/1875/2387 copied (26820.6/37041.5 MiB), 11046.9/13269.9 MiB DL] building offline (buildPhase): downloading https://registry.yarnpkg.com/@babel/plugin-transform-numeric-separator/-/plugin-transform-nu[7/158/614 built (1 failed), 16/1875/2387 copied (26824.6/37041.5 MiB), 11047.6/13269.9 MiB DL] building offline (buildPhase): downloading https://registry.yarnpkg.com/@babel/plugin-transform-numeric-separator/-/plugin-transform-nu[7/158/614 built (1 failed), 16/1875/2387 copied (26828.1/37041.5 MiB), 11048.3/13269.9 MiB DL] building offline (buildPhase): downloading https://registry.yarnpkg.com/@babel/plugin-transform-numeric-separator/-/plugin-transform-nu[7/158/614 built (1 failed), 16/1875/2387 copied (26830.9/37041.5 MiB), 11048.6/13269.9 MiB DL] building offline (buildPhase): downloading https://registry.yarnpkg.com/@babel/plugin-transform-numeric-separator/-/plugin-transform-nu[7/158/614 built (1 failed), 16/1875/2387 copied (26833.1/37041.5 MiB), 11049.1/13269.9 MiB DL] building offline (buildPhase): downloading https://registry.yarnpkg.com/@babel/plugin-transform-numeric-separator/-/plugin-transform-nu
error: 1 dependencies of derivation '/nix/store/ply2qj3gww1mwp46il556lanmmdnr1qm-cider-2-2.5.0-bwrap.drv' failed to build
error: 2 dependencies of derivation '/nix/store/vvhrq315xlj9y35lb4f4szjccggaxqhp-cider-2-2.5.0.drv' failed to build
error: builder for '/nix/store/ss60h88y6lql2x66aps2jjyk2ia8ha8q-pinnwand-1.6.0.drv' failed with exit code 1;
       last 10 log lines:
       >
       > test/integration/test_http_website.py::DeprecatedWebsiteTestCase::test_website_hex
       >   /build/source/src/pinnwand/handler/website.py:408: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
       >     if file.paste.exp_date < datetime.utcnow():
       >
       > -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
       > =========================== short test summary info ============================
       > FAILED test/integration/test_http_api.py::APIv1TestCase::test_api_new_many_file - TimeoutError: Operation timed out after 5 seconds
       > FAILED test/integration/test_http_website.py::WebsiteTestCase::test_website_create_post_many - TimeoutError: Operation timed out after 5 seconds
       > =========== 2 failed, 107 passed, 1 xfailed, 950 warnings in 52.84s ============
       For full logs, run 'nix log /nix/store/ss60h88y6lql2x66aps2jjyk2ia8ha8q-pinnwand-1.6.0.drv'.
error: builder for '/nix/store/0wzxlqrnac9334xa177pks4m1mh72vb2-gotenberg-8.9.1.drv' failed with exit code 1;
       last 10 log lines:
       > {"level":"debug","logger":"nixstorezkb5z6q718n8d1pmvii00w2hspdix4zr-libreoffice-24.2.7.2-wrappedliblibreofficeprogramsoffice.bin","msg":"unix process killed"}
       > {"level":"debug","msg":"'/build/a307da95-8d8a-4b00-ab0d-1f3d5939e77e/302ff7da-3fcc-4546-9c6e-da63e5f90b8c' LibreOffice's user profile directory removed"}
       > --- FAIL: TestLibreOfficeProcess_pdf (33.38s)
       >     --- FAIL: TestLibreOfficeProcess_pdf/success_(PDF/A-3b) (5.01s)
       >         libreoffice_test.go:520: setup error: LibreOffice socket not available: context deadline exceeded
       >     --- FAIL: TestLibreOfficeProcess_pdf/success_(PDF/UA) (5.01s)
       >         libreoffice_test.go:520: setup error: LibreOffice socket not available: context deadline exceeded
       > FAIL
       > FAIL     github.com/gotenberg/gotenberg/v8/pkg/modules/libreoffice/api   44.071s
       > FAIL
       For full logs, run 'nix log /nix/store/0wzxlqrnac9334xa177pks4m1mh72vb2-gotenberg-8.9.1.drv'.
error: builder for '/nix/store/lrxrilmhbqijjvfn6vy1niyplnszl7y6-deltachat-desktop-1.48.0.drv' failed with exit code 1;
       last 10 log lines:
       >
       > Node.js v20.18.0
       >  ELIFECYCLE  Command failed with exit code 1.
       > /build/source/packages/frontend:
       >  ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @deltachat-desktop/frontend@ build: `pnpm build:ts && pnpm build:themes && pnpm build:static && pnpm build:source-map-support && pnpm build:scss`
       > Exit status 1
       > /build/source/packages/target-electron:
       >  ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @deltachat-desktop/target-electron@1.48.0 build: `pnpm build:locales && pnpm build:backend && pnpm --filter=@deltachat-desktop/frontend build && pnpm build:compose-frontend`
       > Exit status 1
       >  ELIFECYCLE  Command failed with exit code 1.
       For full logs, run 'nix log /nix/store/lrxrilmhbqijjvfn6vy1niyplnszl7y6-deltachat-desktop-1.48.0.drv'.
error: 4 dependencies of derivation '/nix/store/cr13j0nqd2i970pdqbn2myrb881fjc9v-env.drv' failed to build
error: 1 dependencies of derivation '/nix/store/svfy0kanzq155b38884zrf9p9pb57zqk-review-shell.drv' failed to build
5 packages failed to build:
cider-2 deltachat-desktop gotenberg pinnwand pinnwand.dist

141 packages built:
_1password-gui _1password-gui-beta affine altair anytype aws-azure-login bazecor beekeeper-studio beeper betaflight-configurator bitwarden-desktop bitwarden-directory-connector blockbench brave bruno caprine chatzone-desktop chromium chromium.sandbox cider code-cursor discord discord-canary discord-development discord-ptb drawio drawio-headless element-desktop element-desktop-wayland emuflight-configurator fast-cli feishin ferdium figma-linux flaresolverr framesh franz freetube geogebra6 github-desktop gitify gitkraken goofcord google-chrome grafana-kiosk gridtracker httptoolkit icestudio inav-configurator itch jitsi-meet-electron joplin-desktop kando keybase-gui koodo-reader kuro legcord lens lunar-client mattermost-desktop mermaid-cli mermaid-filter microsoft-edge morgen mqtt-explorer muffon mullvad-vpn multiviewer-for-f1 netflix nwjs nwjs-sdk obsidian onlykey pandoc-drawio-filter pandoc-drawio-filter.dist percollate pinegrow pinegrow6 playwright-test plexamp podman-desktop popcorntime postman proton-pass protonmail-desktop puppeteer-cli python311Packages.django-filingcabinet python311Packages.django-filingcabinet.dist python311Packages.great-tables python311Packages.great-tables.dist python311Packages.mkdocs-drawio-exporter python311Packages.mkdocs-drawio-exporter.dist python311Packages.pytest-playwright python311Packages.pytest-playwright.dist python311Packages.shiny python311Packages.shiny.dist python312Packages.django-filingcabinet python312Packages.django-filingcabinet.dist python312Packages.great-tables python312Packages.great-tables.dist python312Packages.mkdocs-drawio-exporter python312Packages.mkdocs-drawio-exporter.dist python312Packages.pytest-playwright python312Packages.pytest-playwright.dist python312Packages.shiny python312Packages.shiny.dist r2modman redact redisinsight revolt-desktop ride session-desktop sharedown signal-desktop single-file-cli sitespeed-io slack spotify spotifywm teams-for-linux tidal-hifi uhk-agent uhk-udev-rules ungoogled-chromium ungoogled-chromium.sandbox upscayl vhs vivaldi vscode vscode-extensions.yzane.markdown-pdf vscode-fhs vscode-with-extensions vscodium vscodium-fhs wavebox wayback wootility youtube-music ytmdesktop zettlr zulip

error: build log of '/nix/store/vvhrq315xlj9y35lb4f4szjccggaxqhp-cider-2-2.5.0.drv^*' is not available
error: build log of '/nix/store/w0cygivwz4ykfkaii9kajjj3ymzcp2m4-cider-2-2.5.0' is not available
$ /nix/store/ixjixjj9f1k7h8rqab8frjhl6gm8k466-nix-2.18.8/bin/nix-shell --argstr system x86_64-linux --argstr nixpkgs-path /home/*/.cache/nixpkgs-review/rev-8ae2932d567cbe792ddfebd537be6fd66f594179/nixpkgs --argstr nixpkgs-config-path /tmp/tmpap0htciy.nix --argstr attrs-path /home/*/.cache/nixpkgs-review/rev-8ae2932d567cbe792ddfebd537be6fd66f594179/attrs.nix --nix-path nixpkgs=/home/*/.cache/nixpkgs-review/rev-8ae2932d567cbe792ddfebd537be6fd66f594179/nixpkgs nixpkgs-overlays=/tmp/tmpdr8p23xi /nix/store/88qfwfcy14r5gha7ysb8534dydp3xilb-nixpkgs-review-2.10.4/lib/python3.11/site-packages/nixpkgs_review/nix/review-shell.nix
this derivation will be built:
  /nix/store/61krx4bfhxkg4gl4irym05vjz1nwl142-env.drv
building '/nix/store/61krx4bfhxkg4gl4irym05vjz1nwl142-env.drv'...
warning: collision between (3300+ lines)

34j · 2024-11-24T13:16:59Z

Testing with random apps (entering random Japanese character using Mozc):

app	image
zulip
ytmdesktop
zettlr
postman
obsidian
drawio
bruno
altair	stuck

Scrumplex

Changes LGTM. Seems like none were missed.

34j · 2024-11-25T06:25:06Z

Can this be merged now as the CI passed?

nixos-discourse · 2024-11-25T15:45:20Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4879

khaneliman · 2024-11-28T01:58:47Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 358620

`x86_64-linux`

⏩ 7 packages marked as broken and skipped:

archivebox
archivebox.dist
logseq
lx-music-desktop
micropad
passky-desktop
whalebird

❌ 2 packages failed to build:

cider-2
deltachat-desktop

✅ 141 packages built:

_1password-gui
_1password-gui-beta
affine
altair
anytype
aws-azure-login
bazecor
beekeeper-studio
beeper
betaflight-configurator
bitwarden-desktop
bitwarden-directory-connector
blockbench
brave
bruno
caprine
chatzone-desktop
chromium
chromium.sandbox
cider
code-cursor
discord
discord-canary
discord-development
discord-ptb
drawio
drawio-headless
element-desktop
element-desktop-wayland
emuflight-configurator
fast-cli
feishin
figma-linux
flaresolverr
framesh
freetube
github-desktop
gitify
gitkraken
goofcord
google-chrome
gotenberg
grafana-kiosk
gridtracker
httptoolkit
icestudio
inav-configurator
itch
jitsi-meet-electron
joplin-desktop
kando
keybase-gui
koodo-reader
kuro
legcord
lens
lunar-client
mattermost-desktop
mermaid-cli
mermaid-filter
microsoft-edge
morgen
mqtt-explorer
muffon
mullvad-vpn
multiviewer-for-f1
netflix
nwjs
nwjs-sdk
obsidian
onlykey
pandoc-drawio-filter
pandoc-drawio-filter.dist
percollate
pinegrow
pinegrow6
pinnwand
pinnwand.dist
playwright-test
plexamp
podman-desktop
popcorntime
postman
proton-pass
protonmail-desktop
puppeteer-cli
python311Packages.django-filingcabinet
python311Packages.django-filingcabinet.dist
python311Packages.great-tables
python311Packages.great-tables.dist
python311Packages.mkdocs-drawio-exporter
python311Packages.mkdocs-drawio-exporter.dist
python311Packages.pytest-playwright
python311Packages.pytest-playwright.dist
python311Packages.shiny
python311Packages.shiny.dist
python312Packages.django-filingcabinet
python312Packages.django-filingcabinet.dist
python312Packages.great-tables
python312Packages.great-tables.dist
python312Packages.mkdocs-drawio-exporter
python312Packages.mkdocs-drawio-exporter.dist
python312Packages.pytest-playwright
python312Packages.pytest-playwright.dist
python312Packages.shiny
python312Packages.shiny.dist
r2modman
redact
redisinsight
revolt-desktop
ride
session-desktop
sharedown
signal-desktop
single-file-cli
sitespeed-io
slack
spotify
spotifywm
teams-for-linux
tidal-hifi
uhk-agent
uhk-udev-rules
ungoogled-chromium
ungoogled-chromium.sandbox
upscayl
vhs
vivaldi
vscode
vscode-extensions.yzane.markdown-pdf
vscode-fhs
vscode-with-extensions
vscodium
vscodium-fhs
wavebox
wayback
wootility
youtube-music
ytmdesktop
zettlr
zulip

`aarch64-linux`

⏩ 14 packages marked as broken and skipped:

archivebox
archivebox.dist
betaflight-configurator
emuflight-configurator
gridtracker
icestudio
inav-configurator
lx-music-desktop
micropad
onlykey
passky-desktop
spotifywm
uhk-udev-rules
whalebird

❌ 2 packages failed to build:

python311Packages.django-filingcabinet
python311Packages.django-filingcabinet.dist

✅ 90 packages built:

_1password-gui
_1password-gui-beta
aws-azure-login
beekeeper-studio
bitwarden-desktop
bitwarden-directory-connector
blockbench
brave
bruno
caprine
chromium
chromium.sandbox
deltachat-desktop
drawio
drawio-headless
element-desktop
element-desktop-wayland
fast-cli
feishin
flaresolverr
freetube
github-desktop
gitify
goofcord
gotenberg
grafana-kiosk
httptoolkit
jitsi-meet-electron
kando
koodo-reader
kuro
legcord
mattermost-desktop
mermaid-cli
mermaid-filter
mqtt-explorer
mullvad-vpn
obsidian
pandoc-drawio-filter
pandoc-drawio-filter.dist
percollate
pinnwand
pinnwand.dist
playwright-test
podman-desktop
postman
puppeteer-cli
python311Packages.great-tables
python311Packages.great-tables.dist
python311Packages.mkdocs-drawio-exporter
python311Packages.mkdocs-drawio-exporter.dist
python311Packages.pytest-playwright
python311Packages.pytest-playwright.dist
python311Packages.shiny
python311Packages.shiny.dist
python312Packages.django-filingcabinet
python312Packages.django-filingcabinet.dist
python312Packages.great-tables
python312Packages.great-tables.dist
python312Packages.mkdocs-drawio-exporter
python312Packages.mkdocs-drawio-exporter.dist
python312Packages.pytest-playwright
python312Packages.pytest-playwright.dist
python312Packages.shiny
python312Packages.shiny.dist
r2modman
redisinsight
revolt-desktop
ride
sharedown
signal-desktop
single-file-cli
sitespeed-io
teams-for-linux
tidal-hifi
ungoogled-chromium
ungoogled-chromium.sandbox
upscayl
vhs
vivaldi
vscode
vscode-extensions.yzane.markdown-pdf
vscode-fhs
vscode-with-extensions
vscodium
vscodium-fhs
wayback
wootility
youtube-music
ytmdesktop

`x86_64-darwin`

⏩ 6 packages marked as broken and skipped:

micropad
onlykey
passky-desktop
uhk-udev-rules
vscode-fhs
vscodium-fhs

✅ 4 packages built:

element-desktop-wayland
vscode
vscode-with-extensions
vscodium

`aarch64-darwin`

⏩ 6 packages marked as broken and skipped:

micropad
onlykey
passky-desktop
uhk-udev-rules
vscode-fhs
vscodium-fhs

✅ 4 packages built:

element-desktop-wayland
vscode
vscode-with-extensions
vscodium

34j · 2024-11-28T02:19:18Z

I am not familiar with nixpkgs, but does the build failure depend on whether or not a flag is passed?

khaneliman · 2024-11-28T02:29:31Z

I am not familiar with nixpkgs, but does the build failure depend on whether or not a flag is passed?

I'm just always curious to see how many packages are affected by any given change and what the current status of builds are. In this case, it shouldn't affect the outcome of a given build.

Resolves crash: Unknown flag: --enable-wayland-ime=true Partially reverts #358620

add --enable-wayland-ime flag to all Electron packages that uses `N…

8ae2932

…IXOS_OZONE_WL`

github-actions bot added the 6.topic: vscode A free and versatile code editor that supports almost every major programming language. label Nov 24, 2024

nix-owners bot requested a review from emilylange November 24, 2024 04:36

NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Nov 24, 2024

34j changed the title ~~add --enable-wayland-ime flag to all Electron packages that uses NIXOS_OZONE_WL~~ various: add --enable-wayland-ime flag to all Electron packages that uses NIXOS_OZONE_WL Nov 24, 2024

JohnRTitor changed the title ~~various: add --enable-wayland-ime flag to all Electron packages that uses NIXOS_OZONE_WL~~ treewide: add --enable-wayland-ime flag to all Electron packages that uses NIXOS_OZONE_WL Nov 24, 2024

Scrumplex approved these changes Nov 24, 2024

View reviewed changes

ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Nov 24, 2024

wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 25, 2024

khaneliman approved these changes Nov 28, 2024

View reviewed changes

wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 28, 2024

Scrumplex merged commit 01c33fb into NixOS:master Nov 29, 2024

34j deleted the enable-wayland-ime branch November 30, 2024 01:16

nbdd0121 mentioned this pull request Dec 1, 2024

zulip: build package from source #279545

Merged

13 tasks

34j mentioned this pull request Dec 3, 2024

unstable.vscode with NIXOS_OZONE_WL=1 no longer accepts a file argument #361330

Closed

kachick mentioned this pull request Dec 4, 2024

zettlr: 3.2.0 -> 3.3.1 and make it possible to take commandLineArgs #357759

Closed

13 tasks

nbdd0121 mentioned this pull request Dec 6, 2024

[Backport release-24.11] zulip: build package from source #362394

Merged

13 tasks

AndrewKvalheim mentioned this pull request May 26, 2025

joplin-desktop: revert addition of --enable-wayland-ime #411104

Merged

13 tasks

r-vdp pushed a commit that referenced this pull request May 26, 2025

joplin-desktop: revert addition of --enable-wayland-ime

838dcf1

Resolves crash: Unknown flag: --enable-wayland-ime=true Partially reverts #358620

teutat3s mentioned this pull request Oct 17, 2025

signal-desktop: 7.73.0 -> 7.75.1 #452197

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

treewide: add `--enable-wayland-ime` flag to all Electron packages that uses `NIXOS_OZONE_WL`#358620

treewide: add `--enable-wayland-ime` flag to all Electron packages that uses `NIXOS_OZONE_WL`#358620
Scrumplex merged 1 commit intoNixOS:masterfrom
34j:enable-wayland-ime

34j commented Nov 24, 2024 •

edited

Loading

Uh oh!

34j commented Nov 24, 2024

Uh oh!

34j commented Nov 24, 2024 •

edited

Loading

Uh oh!

Scrumplex left a comment

Uh oh!

34j commented Nov 25, 2024 •

edited

Loading

Uh oh!

nixos-discourse commented Nov 25, 2024

Uh oh!

khaneliman commented Nov 28, 2024

Uh oh!

34j commented Nov 28, 2024

Uh oh!

khaneliman commented Nov 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

34j commented Nov 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

34j commented Nov 24, 2024

Uh oh!

34j commented Nov 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Scrumplex left a comment

Choose a reason for hiding this comment

Uh oh!

34j commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nixos-discourse commented Nov 25, 2024

Uh oh!

khaneliman commented Nov 28, 2024

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

Uh oh!

34j commented Nov 28, 2024

Uh oh!

khaneliman commented Nov 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

34j commented Nov 24, 2024 •

edited

Loading

34j commented Nov 24, 2024 •

edited

Loading

34j commented Nov 25, 2024 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`