Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
Note that we might want to wait for electron 35.0.1 to be packaged in nixpkgs |
andersk
reviewed
Mar 17, 2025
pkgs/by-name/zu/zulip/package.nix
Outdated
Contributor
There was a problem hiding this comment.
We need to pin a specific Electron major version: #279545 (comment)
Yes, electron_35 is what I’m waiting for. I got a couple steps in to packaging that myself but not all the way through, and it looks like there’s more progress here now:
Member
There was a problem hiding this comment.
The electron_35 PR is now merged into master.
13 tasks
Member
|
andersk
approved these changes
Mar 26, 2025
andersk
added
8.has: package (update)
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #389765.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.