falkor: init at 0.0.92

[IceDBorn]

Falkor is an Electron-based gaming hub.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4849

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2120

[IceDBorn]

@JohnRTitor

[JohnRTitor]

Is source build not possible here?

[IceDBorn]

@JohnRTitor Looking at various issues, it seems like electron-builder does not work with nix.

[JohnRTitor]

set hydraPlatforms = [ ]; here

[TomaSajt]

@JohnRTitor , why was this needed? Is this here to avoid caching the package? And if yes, why?

[JohnRTitor]

Yes, this is to put a light load on nix cache. These packages are not source builds, so it's safe to let them build locally.

This is not required persay, but good practice.

[TomaSajt]

There are ways to use electron-builder, though they are quite hacky.
See github search for examples
Will try to figure something out tomorrow.

[JohnRTitor]

There is #279545 which could be used as an example, both are npm packages I think?

[IceDBorn]

There is #279545 which could be used as an example, both are npm packages I think?

Nope, this one is using yarn.

[JohnRTitor]

This could work, I haven't tried it though.

nixpkgs/doc/languages-frameworks/javascript.section.md

Line 530 in 79f0b0e

Yarn based projects use a `yarn.lock` file instead of a `package-lock.json` to pin dependencies. Nixpkgs provides the Nix function `fetchYarnDeps` which fetches an offline cache suitable for running `yarn install` before building the project. In addition, Nixpkgs provides the hooks:

[TomaSajt]

Looked into it, and while it would be possible to package from source, the users would have to provide their own API keys for the build, which is unfortunate.

I'm guessing the prebuilt package contains the keys internally (using import.meta.env to embed them with vite)

I doubt the package authors want us to scrape those values, so I think packaging the prebuilt app is the way to go.

[IceDBorn]

@TomaSajt So? Should this be merged then?

[JohnRTitor]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 357021

[JohnRTitor]

nixpkgs-review couldn't build it for some reason, but I was able to build and run it successfully.