electron-fiddle: 0.36.6 -> 0.36.6-unstable-2025-07-17, bump electron

[TomaSajt]

Related: #397918

Nodejs version doesn't matter that much, upstream just constrains it to be nodejs>=20

The electron version used by upstream is electron 33, which has been EOL for a while.

I bumped the package to a revision where they bumped the electron version to 36.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[andersk]

Since this is a very meta package (electron binary downloader + code-editor + run-the-code-using-the-downloaded-electron), I'd assume it would work with any electron version.

We can’t just assume things! The “meta”ness has nothing to do with it—electron-fiddle is a normal Electron app that happens to also have some “meta” functionality, and all concerns that apply to normal Electron apps apply here as well. Electron adds breaking changes in almost every major release—see #279545 (comment) and #295770 (comment), for example. Even if this happens to work at this moment in time, it’s definitely going to break in the future.

[TomaSajt]

Okay, so, are you planning on keeping it electron_33, even when it is EOL?

Would you be fine with just pinning it to electron_34?

[TomaSajt]

@andersk I have updated the PR to not unlock the electron version, only pin it to a non EOL version. This way we'll still need to check if using electron_35 is fine, but it won't break unannounced later.

[teutat3s]

Upstream did bump their electron version to 36 recently, but no release yet. electron/fiddle#1713

EDIT: Motivation: electron-fiddle is the last package preventing us from dropping EOL electron_33-bin from nixpkgs.

[TomaSajt]

Seems to be working okay, we can merge soon.
(I'd wait a day so that @andersk may have time to review)