treewide/applications: add sourceType binaryNativeCode for many packages#176823
Merged
Mindavi merged 3 commits intoNixOS:masterfrom Jun 23, 2022
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
😕 |
Member
|
Maybe because it is unfree? |
Contributor
Author
|
There are plenty of other unfree packages I touched here though. |
Contributor
Author
|
I'm not tremendously worried about it TBH.. |
risicle
force-pushed
the
ris-native-source-provenance-applications
branch
2 times, most recently
from
5e068b3 to
32b8df9
Compare
This was referenced Jun 13, 2022
risicle
force-pushed
the
ris-native-source-provenance-applications
branch
from
32b8df9 to
5a616c9
Compare
Contributor
Author
|
@ofborg eval |
risicle
requested review from
aforemny,
alyssais,
asymmetric,
kevincox and
samueldr
kevincox
reviewed
Jun 14, 2022
Contributor
There was a problem hiding this comment.
Can you share a bit of info how this change was generated? Particularly how were "packages where binary native code makes it from the downloaded src to the output" packages identified?
Contributor
Author
There was a problem hiding this comment.
A few methods.
A first pass to find candidates used a grep for either architecture names in urls or uses of patchelf. Then I would look manually at the source package(s) if I had any doubts and try and figure out if the binaries made it to the output.
risicle
force-pushed
the
ris-native-source-provenance-applications
branch
from
5a616c9 to
c988bdb
Compare
ofborg
bot
added
the
2.status: merge conflict
risicle
force-pushed
the
ris-native-source-provenance-applications
branch
from
c988bdb to
2fb78c8
Compare
ofborg
bot
removed
the
2.status: merge conflict
risicle
force-pushed
the
ris-native-source-provenance-applications
branch
from
2fb78c8 to
07a0a20
Compare
13 tasks
risicle
force-pushed
the
ris-native-source-provenance-applications
branch
from
07a0a20 to
ed6323a
Compare
this is confusing as it is not used - the package .deb only contains python (and bash)
risicle
force-pushed
the
ris-native-source-provenance-applications
branch
from
ed6323a to
16bca8d
Compare
Mindavi
approved these changes
Jun 23, 2022
Contributor
|
Cherry picked some tens of packages and checked, all looked ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Again, not comprehensive. These are packages where binary native code makes it from the downloaded
srcto the output.Done for both free and unfree packages as it seemed easier not to differentiate when it came to it.
Skips AppImages as I'm guessing it'll be easier to handle them all together. (edit see #177308)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes