appimageTools.wrapAppImage: default produced derivations to sourceProvenance binaryNativeCode#177308
Merged
risicle merged 1 commit intoNixOS:masterfrom Jun 20, 2022
Conversation
…venance binaryNativeCode
ofborg
bot
added
10.rebuild-darwin: 0
This was referenced Jun 12, 2022
risicle
requested review from
aforemny,
alyssais,
asymmetric,
kevincox and
samueldr
kevincox
approved these changes
Jun 14, 2022
Contributor
kevincox
left a comment
kevincox
left a comment
There was a problem hiding this comment.
I'm ok with this. But please give a week or so for objections.
| @@ -37,14 +37,24 @@ rec { | |||
| extractType2 = extract; | |||
Contributor
There was a problem hiding this comment.
Is it worth trying to do some analysis to see if there are exceptions? Or will we apply those in follow ups (if they exist)?
Contributor
Author
There was a problem hiding this comment.
I'm really hoping this is all just a first pass and maintainers will continually refine things. But I've left in the possibility of override so they can.
bobby285271
added
the
12.approvals: 1
aforemny
approved these changes
Jun 16, 2022
bobby285271
added
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This still allows special cases to override their
sourceProvenance, but in the vast vast majority of cases AppImages will contain opaque binary native code.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes