Skip to content

treewide/games,misc: add sourceType binaryNativeCode for many packages#177212

Merged
risicle merged 1 commit intoNixOS:masterfrom
risicle:ris-native-source-provenance-games-misc
Jun 16, 2022
Merged

treewide/games,misc: add sourceType binaryNativeCode for many packages#177212
risicle merged 1 commit intoNixOS:masterfrom
risicle:ris-native-source-provenance-games-misc

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Jun 10, 2022

Description of changes

See also #177202, #176823

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 10, 2022
@risicle
Copy link
Contributor Author

risicle commented Jun 14, 2022

@ofborg eval

Copy link
Contributor

@aforemny aforemny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the changed derivations and given source provenances seem reasonable to me!

Copy link
Contributor

@kevincox kevincox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've spot checked a bunch of these and they look good. IIUC there isn't a big impact for false-positives right now so we can fix mistakes as we go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants