Skip to content

treewide/python-modules: add sourceProvenance for several packages#178251

Merged
FRidh merged 1 commit intoNixOS:masterfrom
risicle:ris-source-provenance-python-modules
Jun 20, 2022
Merged

treewide/python-modules: add sourceProvenance for several packages#178251
FRidh merged 1 commit intoNixOS:masterfrom
risicle:ris-source-provenance-python-modules

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Jun 19, 2022

Description of changes

These were discovered by scanning python modules' src inputs for likely-looking binary files, then checked manually.

See also #176823, #178057, #178059

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@risicle risicle requested review from FRidh and jonringer as code owners June 19, 2022 14:29
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 19, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 19, 2022
@FRidh
Copy link
Member

FRidh commented Jun 19, 2022

sdist should not contain any bytecode.

@risicle
Copy link
Contributor Author

risicle commented Jun 19, 2022

All the cases here that add binaryBytecode refer to .jars being included.

@FRidh FRidh merged commit 444d3a8 into NixOS:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants