Skip to content

various packages: mark meta.sourceProvenance#175732

Merged
aforemny merged 12 commits intoNixOS:masterfrom
FliegendeWurst:source-provenance
Jun 13, 2022
Merged

various packages: mark meta.sourceProvenance#175732
aforemny merged 12 commits intoNixOS:masterfrom
FliegendeWurst:source-provenance

Conversation

@FliegendeWurst
Copy link
Member

@FliegendeWurst FliegendeWurst commented Jun 1, 2022

Description of changes

See NixOS/rfcs#89 / #161098

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 1, 2022
@FliegendeWurst FliegendeWurst requested a review from aforemny June 4, 2022 18:56
Copy link
Contributor

@aforemny aforemny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FliegendeWurst, could you please rebase onto 3b6bc4b and fix the failing evaluation for josm? After rebasing, sourceProvenance is declared there twice.

Otherwise LGTM! Thanks!

@FliegendeWurst
Copy link
Member Author

Rebased onto latest master, dropped josm commit.

Copy link
Contributor

@aforemny aforemny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aforemny aforemny merged commit f5389ce into NixOS:master Jun 13, 2022
@risicle
Copy link
Contributor

risicle commented Jun 13, 2022

Please see #176823, #177202, #177212, #177280, #177308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants