Skip to content

treewide/development: add sourceType binaryNativeCode for many packages#177202

Merged
risicle merged 1 commit intoNixOS:masterfrom
risicle:ris-native-source-provenance-development
Jun 16, 2022
Merged

treewide/development: add sourceType binaryNativeCode for many packages#177202
risicle merged 1 commit intoNixOS:masterfrom
risicle:ris-native-source-provenance-development

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Jun 10, 2022

Description of changes

Excluding compilers and interpreters as some new tricks may be needed to cover their various bootstrapping processes properly.

See also #176823

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@risicle risicle requested review from FRidh and jonringer as code owners June 10, 2022 19:07
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 10, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 10, 2022
@risicle
Copy link
Contributor Author

risicle commented Jun 14, 2022

@ofborg eval

@risicle risicle force-pushed the ris-native-source-provenance-development branch from 782ee7c to 66e892b Compare June 15, 2022 23:17
Copy link
Contributor

@kevincox kevincox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot-checked this and it looks good. IIUC right now there is no major impact of false-positives so we can tweak as we go.

excluding compilers and interpreters as some new tricks may be
needed to cover their various bootstrapping processes properly
@risicle risicle force-pushed the ris-native-source-provenance-development branch from 66e892b to 12eea1c Compare June 16, 2022 19:19
@risicle
Copy link
Contributor Author

risicle commented Jun 16, 2022

Rebased to check for eval failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants