Skip to content

llvmPackages_latest: 11 -> 12#116646

Merged
primeos merged 1 commit intoNixOS:stagingfrom
ggreif:llvm-12
Jun 2, 2021
Merged

llvmPackages_latest: 11 -> 12#116646
primeos merged 1 commit intoNixOS:stagingfrom
ggreif:llvm-12

Conversation

@ggreif
Copy link
Contributor

@ggreif ggreif commented Mar 17, 2021 •
edited
Loading

https://lists.llvm.org/pipermail/release-testers/2021-March/001496.html

Fixes #116629.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 17, 2021
@ofborg ofborg bot requested review from 7c6f434c, dtzWill, lovek323 and primeos March 17, 2021 17:37
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. and removed 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. labels Mar 17, 2021
@ggreif
Copy link
Contributor Author

ggreif commented Mar 17, 2021

@GrahamcOfBorg build llvmPackages_12

@ofborg ofborg bot added 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 17, 2021
@ggreif
Copy link
Contributor Author

ggreif commented Mar 17, 2021

When this is merged, reverting 759b50f on staging might be a good idea (sometime in the future).

SuperSandro2000
SuperSandro2000 reviewed Mar 17, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some idea to modernize the expression a bit

ggreif
ggreif commented Mar 18, 2021
View reviewed changes
pkgs/development/compilers/llvm/12/default.nix Outdated
Copy link
Contributor Author

@ggreif ggreif Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should revisit this.

@primeos primeos mentioned this pull request Mar 19, 2021
Closed
@primeos
Copy link
Member

primeos commented Mar 31, 2021

@GrahamcOfBorg build llvmPackages_12.stdenv

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 1, 2021
@primeos primeos changed the title llvmPackages_12: start with rc3 (mostly copy 11.1.0) llvmPackages_12: 12.0.0 Apr 1, 2021
@primeos primeos mentioned this pull request Apr 17, 2021
Merged
10 tasks
@ggreif ggreif marked this pull request as ready for review April 18, 2021 00:33
@Ericson2314
Copy link
Member

Ericson2314 commented Apr 28, 2021

Wow, it's a bit scary this is a mass rebuild.

@primeos
Copy link
Member

primeos commented Apr 28, 2021

@Ericson2314 yeah. I haven't checked yet but hopefully it's just due to mesa. I've noticed that a8aeef7 is in master now so after this rebase it should hopefully look much better.

@ofborg ofborg bot added 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Apr 28, 2021
@Ericson2314
Copy link
Member

Ericson2314 commented Apr 28, 2021

@primeos Oh nice, I feel much better now :).

primeos referenced this pull request Apr 29, 2021
@ggreif @primeos
llvmPackages_12: init at 12.0.0-rc3
7c27d49 
https://lists.llvm.org/pipermail/release-testers/2021-March/001496.html
@ggreif ggreif mentioned this pull request May 27, 2021
Merged
9 tasks
@primeos primeos changed the base branch from master to staging June 2, 2021 20:59
@primeos
Copy link
Member

primeos commented Jun 2, 2021

I've tried to test this a few days ago using nixpkgs-review but it was even worse than I thought and I ran out of disk space too quickly. At least 21 builds still succeed and all of the failures where unrelated:

1093 packages updated:
[...]
21 packages built:
Sylk _1password-gui appgate-sdp asymptote atom avocode azuredatastudio bat-extras.prettybat bitwarden blur-effect brave cardboard ccls clangAnalyzer clang-tools google-cloud-cpp libGL_driver lldb lldb_11 mesa mycrypto

Let's test this on staging due to the lack of a dedicated Hydra jobset and to avoid that llvmPackages_latest remains outdated. I guess it should be (mostly) fine but please ping me / this thread if you notice any issues.

@primeos primeos merged commit 3045b00 into NixOS:staging Jun 2, 2021
@Ericson2314
Copy link
Member

Ericson2314 commented Jun 2, 2021

Thanks!

@Ericson2314
Copy link
Member

Ericson2314 commented Jun 3, 2021 •
edited
Loading

nixpkgs/pkgs/top-level/all-packages.nix

Line 11426 in 2a1c29e

else 11; # latest

Unfortunately we need to get that too. I wish there was a way to de-dup.

primeos added a commit to primeos/nixpkgs that referenced this pull request Jun 3, 2021
@primeos
llvmPackages: Extract the latest LLVM version from llvmPackages_latest
df88d51 
That way we only have to bump the latest LLVM version in one place and
avoid forgetting about the second occurrence like I did in NixOS#116646.
@primeos primeos mentioned this pull request Jun 3, 2021
Merged
9 tasks
@primeos
Copy link
Member

primeos commented Jun 3, 2021

@Ericson2314 good catch, I wasn't even aware of that 2nd occurrence, thanks!
+1 for the deduplication, I've drafted an implementation in #125478 (it should be fine for Nixpkgs but could potentially cause issues with some overlays/patches - I guess it should be fine though and hopefully we'll soon have a llvmPackages_git for that (#120780)).

@knedlsepp
Copy link
Member

knedlsepp commented Jun 23, 2021 •
edited
Loading

I just noticed that llvmPackages_latest doesn't point to llvmPackages_12 on the 21.05 release. Should this be backported?

@primeos
Copy link
Member

primeos commented Jun 23, 2021

IMO it's too late for that now (it can be a breaking change if you depend on llvmPackages_latest) but I suppose if someone would offer / be able to properly test it for Nixpkgs we could consider backporting it (someone would have to ACK it though and we lack LLVM maintainers).

@Mindavi Mindavi mentioned this pull request Jun 23, 2021
Closed
3 tasks
@TredwellGit TredwellGit mentioned this pull request Jun 23, 2021
Closed
10 tasks
@TredwellGit TredwellGit mentioned this pull request Jul 9, 2021
Closed
rvem pushed a commit to serokell/nixpkgs that referenced this pull request Nov 8, 2022
@primeos @rvem
llvmPackages_12: 12.0.0-rc4 -> 12.0.0-rc5
5199635 
Note: Tested in NixOS#116646.
(cherry picked from commit 2b95bf4)
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@primeos primeos Awaiting requested review from primeos

@lovek323 lovek323 Awaiting requested review from lovek323

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees

No one assigned

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LLVM 12

6 participants

@ggreif @primeos @Ericson2314 @knedlsepp @SuperSandro2000 @rrbutani