Conversation
to see what breaks, and also to get NixOS/nixpkgs@5a923e5 which may allow us to use `rustc` from `nixpkgs` again (see #2519)
This reverts commit d5e3399.
|
This PR does not affect the produced WebAssembly code. |
Contributor
Author
|
Claudio wants to test this, so don’t merge before. Might be nice if someone on OSX would test using the |
Contributor
|
Hmm, my Mac exhibits the same failure mode as the I have seen this happening on the |
Contributor
Author
|
I am surprised you have to build that at all - isn't it part of our nix cache by now? |
Contributor
|
Testing it now... (just by running nix-shell - lemme know if you want more). |
Contributor
|
Works for me! |
crusso
reviewed
May 27, 2021
crusso
reviewed
May 27, 2021
crusso
reviewed
May 27, 2021
crusso
reviewed
May 27, 2021
crusso
reviewed
May 27, 2021
crusso
approved these changes
May 27, 2021
Contributor
crusso
left a comment
There was a problem hiding this comment.
Approved, but see suggestions for typos and issue filing
Co-authored-by: Claudio Russo <claudio@dfinity.org>
nomeata
added a commit
that referenced
this pull request
Aug 25, 2021
in #2532 we added a patch related to static building of ocaml packages, submitted to nixpkgs as NixOS/nixpkgs#124498, but it was never merged upstream. Supposedly a patch from NixOS/nixpkgs#135619 fixes it as well (and maybe more properly). So let’s try that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to see what breaks, and also to get
NixOS/nixpkgs@5a923e5
which may allow us to use
rustcfromnixpkgsagain (see #2519)Issues encountered:
in nixpks, various
cargoSHA256were wrong. (rav1e: fix cargoSha256 NixOS/nixpkgs#123522, cargo-c: Fix cargoSha256 NixOS/nixpkgs#123348, rust-bindgen: Update cargoSha256 NixOS/nixpkgs#123349)Ocaml built with musl, used for static builds, is currently broken.
Reported at pkgsMusl.ocamlPackages.ocaml: -r and -pie may not be used together NixOS/nixpkgs#124476.
Found a possible fix, submitted at pkgsMusl.ocamlPackages.ocaml: Disable pie hardening on musl NixOS/nixpkgs#124498 and currently included in this branch.
New ocamlformat version
Running new formatter on these files
The RTS fails to build or link the C files (
stddef.hmissing)This stuff was very hairy before, and that doesn’t get better :-(
If I use the wrapped
wasm32-unknown-wasi-clang, the build makes some progress, but then fails with https://bugs.llvm.org/show_bug.cgi?id=43393 (as it used to before, and then somehow we fixed that)In the end, surgically adding an include to
CLANG_FLAGSworks, it seems.Some upgraded tool produces new
namessubsections, presumably from this Wasm proposal: https://github.com/WebAssembly/extended-name-section/blob/master/proposals/extended-name-section/Overview.mdWorked around by jumping over them, but otherwise ignoring them. Should be refined.
Haskell code ought to be adjusted to latest GHC
Bump the
nivthat we install into the shell (also because of Haskell changes)The darwin rebuild of
rustcandgitkeeps timing out on hydra.