Skip to content

llvmPackages: Extract the latest LLVM version from llvmPackages_latest#125478

Merged
Ericson2314 merged 1 commit intoNixOS:stagingfrom
primeos:llvmPackages-dedup-latest-version
Jun 3, 2021
Merged

llvmPackages: Extract the latest LLVM version from llvmPackages_latest#125478
Ericson2314 merged 1 commit intoNixOS:stagingfrom
primeos:llvmPackages-dedup-latest-version

Conversation

@primeos
Copy link
Member

@primeos primeos commented Jun 3, 2021

That way we only have to bump the latest LLVM version in one place and
avoid forgetting about the second occurrence like I did in #116646.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

That way we only have to bump the latest LLVM version in one place and
avoid forgetting about the second occurrence like I did in NixOS#116646.
@primeos primeos mentioned this pull request Jun 3, 2021
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 3, 2021
@Ericson2314
Copy link
Member

Hehe nice trick!

@Ericson2314 Ericson2314 merged commit 1f74f98 into NixOS:staging Jun 3, 2021
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments