Skip to content

llvmPackages_git: init at 12.0.0#120780

Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom
primeos:llvm_git
Jun 3, 2021
Merged

llvmPackages_git: init at 12.0.0#120780
Ericson2314 merged 2 commits intoNixOS:masterfrom
primeos:llvm_git

Conversation

@primeos
Copy link
Member

@primeos primeos commented Apr 26, 2021

Motivation for this change

The purpose of this package is to continuously improve the LLVM packaging in Nixpkgs without causing a lot of rebuilds and provide more recent LLVM builds for users. For more details see: #114828

$ nix-build -A llvmPackages_git
/nix/store/43rydlkccryd5qimyhzcd770p77xa9y9-llvm-binutils-12.0.0
/nix/store/ai182d04qkq6v9inf7qlxfx3y9yjyi2m-clang-wrapper-12.0.0
/nix/store/qy5pvnfi4lbpzaqb6yvf19id6mdbj1rr-clang-manpages-12.0.0
/nix/store/11ycphkxb283ckyv7wi4dsac12ndzvvm-clang-12.0.0
/nix/store/l8zi1amkzzyv86rizx6mhpjdxdhg078k-compiler-rt-12.0.0
/nix/store/yk3382ljb3na18zfix91yr4a52j829h4-clang-12.0.0-lib
/nix/store/n8maaw1i8fndn753h3kxd2hzj3dvg1k6-libcxx-12.0.0
/nix/store/ymmwrcsm85jwihw2dr1dp2jhszdh83ib-clang-wrapper-12.0.0
/nix/store/mr8id74d4pwx561j2x91a6q21ahcfixf-stdenv-linux
/nix/store/y440kbmbppwjw807a0mzp887dr950cak-libcxxabi-12.0.0
/nix/store/bxggsaya2cwsyn5jjqa8g920pka5kb1q-libunwind-12.0.0
/nix/store/xg9a207gb8x3k94rljms32avs74j9km9-lld-12.0.0
/nix/store/y2kmhk05mdbnlilg8h6v7kh7aivc927c-clang-wrapper-12.0.0
/nix/store/2q5gjziz0ypnfmymi40w5kxyzbhwx550-clang-wrapper-12.0.0
/nix/store/w8x2gm41n4pwfmjqn001q2p9b3as334s-clang-wrapper-12.0.0
/nix/store/6pfn9bjvj6zql78xdm7n91vh52jsalf5-clang-wrapper-12.0.0
/nix/store/6hdjs3s2cf344rs31p3rjvzlz9kdnqvk-lldb-12.0.0
/nix/store/wkzrmqg19r1360kgh95kz4gwqwa00w9m-llvm-12.0.0
/nix/store/nrf24399h429ms4bg9akgvips2blss2j-openmp-12.0.0
/nix/store/4kcqsxngfk03j0097zmv788zwcsjjd7c-stdenv-linux
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos primeos requested a review from matthewbauer as a code owner April 26, 2021 19:50
@primeos primeos linked an issue Apr 26, 2021 that may be closed by this pull request
llvm_11: build from git #114828
Closed
@primeos primeos mentioned this pull request Apr 26, 2021
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 26, 2021
@primeos primeos marked this pull request as draft April 28, 2021 16:34
@primeos primeos mentioned this pull request Jun 3, 2021
Merged
10 tasks
primeos added 2 commits June 3, 2021 20:14
@primeos
llvmPackages_git: Copy from llvmPackages_12
e458a01 
The purpose of this package is to continuously improve the LLVM
packaging in Nixpkgs without causing a lot of rebuilds and provide more
recent LLVM builds for users. For more details see:
NixOS#114828
@primeos
llvmPackages_git: Build from Git
a7f062d 
The version will initially remain the same so that no additional changes
to the packaging are required (i.e. this commit only includes the
required changes to build from the mono repository instead of individual
tarballs).
@primeos
Copy link
Member Author

primeos commented Jun 3, 2021

@ofborg build llvmPackages_git

@primeos primeos marked this pull request as ready for review June 3, 2021 18:37
@primeos
Copy link
Member Author

primeos commented Jun 3, 2021

@Ericson2314 I've re-copied the current llvmPackages_12 from master and cherry-picked my 2nd commit (+ resolved the conflicts).

The src = runCommand "${pname}-src}" {} "take just what we need from ${src}"; part that you've mentioned in #114828 (comment) is still missing though.
I'm fine with any of these three options:

  • We merge this PR as it is (potentially implementing that part later)
  • You have time and motivation to implement it
  • I close this PR (i.e. no llvmPackages_git)

Ericson2314
Ericson2314 approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with just doing the filtering later

@Ericson2314 Ericson2314 merged commit 67eb7b4 into NixOS:master Jun 3, 2021
@primeos primeos mentioned this pull request Nov 27, 2022
Merged
13 tasks
@rrbutani rrbutani mentioned this pull request Jan 8, 2023
Merged
92 tasks
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

llvm_11: build from git

3 participants

@primeos @Ericson2314 @rrbutani